Closed Bug 698157 Opened 13 years ago Closed 13 years ago

Jetpack Tree should show which branch a test is building on

Categories

(Tree Management Graveyard :: TBPL, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: lsblakk, Assigned: philor)

References

Details

Attachments

(1 file)

Today in bug 695921 we turned on additional branches (mozilla-{central,beta,release,aurora}) and build types (opt & debug) for each branch. This results in 4x "JP" across for each build-type/platform line.

It would be useful to have each test suite here show the branch it came from instead (or as well) - either "C M A R" or "JPc JPm JPa JPr" or the like.
Attached patch fix v.1Splinter Review
The whole test name hunk is beginning to smell, but it's one of those smells that your nose gets numbed to pretty quickly.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #571237 - Flags: review?(mstange)
Comment on attachment 571237 [details] [diff] [review]
fix v.1

I'm surprised you went for the capital letters variant. Apart from the sort order, is there anything that differentiates "Jetpack mozilla-central" from "Crashtest"? Ah, I guess crashtests are in the R() group.
Attachment #571237 - Flags: review?(mstange) → review+
Sorry, there was supposed to be a continuation of the comment's thought above the existing "Jetpack SDK Test" line saying something like

// ... while Jetpack tests on normal branches have names like
// "Rev3 Fedora 12 mozilla-central opt test jetpack"

If you're watching tree=Firefox&noignore=1, you'll still be seeing JP. If you're watching tree=Jetpack, it's because you're a Jetpack contributor, and you may well have never heard of crashtests. It did worry me a tiny bit at first, for people who cross the line, but when I see a tree that's

Linux opt     C A B R
Linux debug   C A B

there's not even a second of confusion thinking "that's a crashtest, some A and B, and a reftest," probably because as you say I'm used to seeing them live in R(C J R) and a naked C doesn't say crashtest to me. I have more trouble with mapping a capital letter to a repo, since I almost never call it Aurora, just mozilla-aurora or -aurora or aurora or mostly m-a, but I suspect that's just me.

Myk: would

Linux opt   m-c m-a m-b m-r
Linux debug m-c m-a m-b

(which should instantly tell anyone on the Firefox side of the line what's going on) work better for you, or are the capitals with nothing redundant to distract from the distinctions better?
(In reply to Phil Ringnalda (:philor) from comment #3)
> Myk: would
> 
> Linux opt   m-c m-a m-b m-r
> Linux debug m-c m-a m-b
> 
> (which should instantly tell anyone on the Firefox side of the line what's
> going on) work better for you, or are the capitals with nothing redundant to
> distract from the distinctions better?

Hmm, at first glance, m-* does seem better (even though I was the one who suggested the single capital letters), since they are both globally unique (which helps for folks like me who look at both the Jetpack and Firefox trees) and more reflective of the names of the branches being tested against.

(Similarly, I can imagine jp-d, jp-s, and jp-r nicknames for the SDK's development, stabilization, and release branches on Firefox trees, if we were to start testing all three branches on those trees at some point.)
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/450efb4199c1

Probably make it to production by early next week.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Depends on: 700188
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: