Closed Bug 698195 Opened 12 years ago Closed 12 years ago

Use AfterSetAttr to process script href changes

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla11

People

(Reporter: longsonr, Assigned: longsonr)

Details

Attachments

(1 file)

patch
2.51 KB, patch
dholbert
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch patch — — Splinter Review 
Assignee: nobody → longsonr

        Attachment #570478 -
        Flags: review?(dholbert)

    
    

    
  
Comment on attachment 570478 [details] [diff] [review]
patch

I take it theree's no way to change the target of <script xlink:href="..."> other than setAttributeNS?

I know it's not animatable, and it doesn't seem to be exposed as an attribute on the DOM node.

Assuming that there's no other way to do it (or all ways end up triggering AfterSetAttr), then r=me.

        Attachment #570478 -
        Flags: review?(dholbert) → review+

    
    

    
  
You can change it with SVG DOM but you still end up in AfterSetAttr.
Flags: in-testsuite-

    
    

    
  
pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/64103eac30cf
Target Milestone: --- → mozilla11

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/64103eac30cf
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.