698220 - AwesomeBarTabs and content is not displayed on device rotation

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (10/29)

Currently when one is idle in the AwesomeScreen and rotates ones device, all AwesomeBarTabs and content is removed from the screen and nothing is displayed.

See screenshot

Steps: 

1. Open the AwesomeScreen
2. Rotate device to landscape, and dismiss the virtual keyboard

D/AwesomeBar(  689): creating awesomebar
D/AwesomeBarTabs(  689): Creating AwesomeBarTabs
D/AwesomeBarTabs(  689): Creating All Pages tab
D/AwesomeBarTabs(  689): Creating Bookmarks tab
D/AwesomeBarTabs(  689): Creating History tab


The AwesomeBarTabs are created but nothing is displayed.

--
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111029 Firefox/10.0a1 Fennec/10.0a1
HTC Nexus One (Android 2.3.6)

Comment 1

[Aaron Train [:aaronmt]]

Sriram says in channel that this is due to a trigger on rotation that starts filtering whatever content is in the url bar

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch fixes the issue by listening to orientation changes.
This patch also changes "text" to "mText" for the sake of consistency.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 570813 [details] [diff] [review]
Patch

Seems OK. I don't have any reason to not use the | android:configChanges="orientation" | so let's do it.

Comment 4

[Sriram Ramasubramanian [:sriram]]

This seems to be not landed yet. Could someone please land this?

Comment 5

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/projects/birch/rev/c1881e7e046c

Comment 6

[Aaron Train [:aaronmt]]

20111103114449
http://hg.mozilla.org/projects/birch/rev/c1881e7e046c
Samsung Nexus S (Android 2.3.6)

Comment 7

[Wesley Johnston (:wesj)]

This was backed out because of test failures on an earlier push.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

backout was backed out https://hg.mozilla.org/projects/birch/rev/6f925b45a547

Comment 9

[Aaron Train [:aaronmt]]

20111114041052
http://hg.mozilla.org/projects/birch/rev/859ecdfe0168
Samsung Galaxy SII (Android 2.3.4)