Closed
Bug 698220
Opened 11 years ago
Closed 11 years ago
AwesomeBarTabs and content is not displayed on device rotation
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: aaronmt, Assigned: sriram)
Details
(Keywords: regression)
Attachments
(2 files)
12.58 KB,
image/png
|
Details | |
5.39 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Currently when one is idle in the AwesomeScreen and rotates ones device, all AwesomeBarTabs and content is removed from the screen and nothing is displayed. See screenshot Steps: 1. Open the AwesomeScreen 2. Rotate device to landscape, and dismiss the virtual keyboard D/AwesomeBar( 689): creating awesomebar D/AwesomeBarTabs( 689): Creating AwesomeBarTabs D/AwesomeBarTabs( 689): Creating All Pages tab D/AwesomeBarTabs( 689): Creating Bookmarks tab D/AwesomeBarTabs( 689): Creating History tab The AwesomeBarTabs are created but nothing is displayed. -- Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111029 Firefox/10.0a1 Fennec/10.0a1 HTC Nexus One (Android 2.3.6)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → sriram
Reporter | ||
Comment 1•11 years ago
|
||
Sriram says in channel that this is due to a trigger on rotation that starts filtering whatever content is in the url bar
Assignee | ||
Comment 2•11 years ago
|
||
This patch fixes the issue by listening to orientation changes. This patch also changes "text" to "mText" for the sake of consistency.
Attachment #570813 -
Flags: review?(mark.finkle)
Comment 3•11 years ago
|
||
Comment on attachment 570813 [details] [diff] [review] Patch Seems OK. I don't have any reason to not use the | android:configChanges="orientation" | so let's do it.
Attachment #570813 -
Flags: review?(mark.finkle) → review+
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•11 years ago
|
||
This seems to be not landed yet. Could someone please land this?
Comment 5•11 years ago
|
||
http://hg.mozilla.org/projects/birch/rev/c1881e7e046c
Reporter | ||
Comment 6•11 years ago
|
||
20111103114449 http://hg.mozilla.org/projects/birch/rev/c1881e7e046c Samsung Nexus S (Android 2.3.6)
Status: RESOLVED → VERIFIED
Comment 7•11 years ago
|
||
This was backed out because of test failures on an earlier push.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Comment 8•11 years ago
|
||
backout was backed out https://hg.mozilla.org/projects/birch/rev/6f925b45a547
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 9•11 years ago
|
||
20111114041052 http://hg.mozilla.org/projects/birch/rev/859ecdfe0168 Samsung Galaxy SII (Android 2.3.4)
Status: RESOLVED → VERIFIED
Updated•2 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•