698223 - Display URI in AwesomeBar and results if no title is present

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (10/29)

See screenshot

I/Gecko   ( 1613): Got message: onStateChange
I/GeckoApp( 1613): State - 983041
I/GeckoApp( 1613): Got a document start
I/Gecko   ( 1613): Got message: onLocationChange
I/GeckoApp( 1613): URI - http://mw.weather.com/
I/Tab     ( 1613): Updated url: http://mw.weather.com/ for tab with id: 2
I/Gecko   ( 1613): Got message: onStateChange
I/GeckoApp( 1613): State - 196612
I/Gecko   ( 1613): Got message: DOMTitleChanged
I/GeckoApp( 1613): title - 
I/Gecko   ( 1613): Got message: DOMContentLoaded
I/GeckoApp( 1613): URI - http://mw.weather.com/, title - 

--
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111029 Firefox/10.0a1 Fennec/10.0a1
Samsung Nexus S (Android 2.3.6)

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: (1/2) Use URL as title on tabs when title is empty

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: (2/2) Use title from tab when updating browser toolbar

Comment 3

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 570748 [details] [diff] [review]
(1/2) Use URL as title on tabs when title is empty

This gives a wrong notation in tab management. The title, if "", better be the same.
In the second patch, it can be more like, tab.getTitleString() which can return title or url (if title is not present).
Having url as title in Tab.java is not a good approach to me.

Comment 4

[Lucas Rocha (:lucasr)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #3)
> Comment on attachment 570748 [details] [diff] [review] [diff] [details] [review]
> (1/2) Use URL as title on tabs when title is empty
> 
> This gives a wrong notation in tab management. The title, if "", better be
> the same.
> In the second patch, it can be more like, tab.getTitleString() which can
> return title or url (if title is not present).
> Having url as title in Tab.java is not a good approach to me.

What use cases do you have in mind that this change would break? Anyway, I can add a method called getTitleForDisplay (better than "getTitleString" I think) method and keep getTitle as is.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Rethinkning the mTitle = mURL change

Comment 6

[Lucas Rocha (:lucasr)]

Attachment: (1/3) Always set tab title, even when it's empty

Comment 7

[Lucas Rocha (:lucasr)]

Attachment: (2/3) Add Tab method to return title for display

Comment 8

[Lucas Rocha (:lucasr)]

Attachment: (3/3) Use display title from tab in GeckoApp

Comment 9

[Lucas Rocha (:lucasr)]

Pushed:
http://hg.mozilla.org/projects/birch/rev/7baff6f03b41
http://hg.mozilla.org/projects/birch/rev/f3d482c5a382
http://hg.mozilla.org/projects/birch/rev/aa1d7c37f90f

Comment 10

[Aaron Train [:aaronmt]]

Lucas, do your patches address history items? For example; on visiting the site in comment #0 (e.g, http://mw.weather.com), the site URI is now displayed in the url bar as expected, but upon visiting the history tab and seeing its entry, the site title is missing from the entry  -- would it make sense to repeat the site URI for the listed title?

Comment 11

[Kartikaya Gupta (email:[e-mail])]

(In reply to Aaron Train [:aaronmt] from comment #10)
> Lucas, do your patches address history items? For example; on visiting the
> site in comment #0 (e.g, http://mw.weather.com), the site URI is now
> displayed in the url bar as expected, but upon visiting the history tab and
> seeing its entry, the site title is missing from the entry  -- would it make
> sense to repeat the site URI for the listed title?

This sounds like bug 697803 which I fixed yesterday.

Comment 12

[Aaron Train [:aaronmt]]

Follow-up via bug above.

Comment 13

[Aaron Train [:aaronmt]]

20111101040211
http://hg.mozilla.org/projects/birch/rev/7203d86d5868
Motorola Droid Pro (Android 2.3)