698245 - TryChooser Syntax Builder has mixed content errors because it loads Javascript and CSS from http://ajax.googleapis.com

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

IMO, we shouldn't be relying on Google hosting this for us, and definitely we shouldn't be loading non-HTTPS JS on a mozilla.org site.

<link href="http://ajax.googleapis.com/ajax/libs/jqueryui/1.8/themes/base/jquery-ui.css" rel="stylesheet" type="text/css"/>

<script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jquery/1.4/jquery.min.js"></script>

Comment 1

[Phil Ringnalda (:philor)]

Attachment: self-host and update

I was going to do the fascinating patch of just adding an s to the http, but then I got to looking at Google's docs, and didn't get the impression that they entirely approve of using their CDN without loading up their jsapi?key= crud with your API key first, and I doubt we'd be getting any great CDN benefit while having to set up an https connection to them just to download a couple of tiny files, so instead I grabbed a copy of a more recent jQuery than what we were using (which doesn't break anything that I could see), and hg added them instead.

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 570529 [details] [diff] [review]
self-host and update

thank you for doing this

Comment 3

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/build/tools/rev/2b3920fd4a6e

I'm not sure how either copy of the site gets updated, but I'm pretty sure "land before bear can land his patch from bug 697473 so it's his problem" will be a workable solution for me :)

Comment 4

[Mike Taylor [:bear]]

Comment on attachment 570529 [details] [diff] [review]
self-host and update

these were added as part of changeset 2b3920fd4a6e

Comment 5

[Phil Ringnalda (:philor)]

Wound up getting deployed with bug 699912, though the https impetus to do it went away with bug 699315