69828 - nsWebBrowserPersist tries to open streams synchronously and asynchronously

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Adam Lock]

nsWebBrowserPersist has some wacky and non-sensical code to open the same 
channel both asynchronously and synchronously. Get rid of one of them, 
preferably the async code.

Comment 1

[Judson Valeski]

hmm, I'd be in favor of using the Async api over the sync one. The sync api is
going to block whatever thread winds up calling it.

Comment 2

[Adam Lock]

Attachment: Patch to remove async code

Comment 3

[Adam Lock]

I have removed the async code for the time being because this does not interfere 
with the intended way this object was supposed to work. Essentially 
nsWebBrowserPersist was meant to return immediately after SaveURI was called and 
then save the content as it arrived via listeners.

I could change it to remove the synchronous code but that would require a more 
substantial modification.

Comment 4

[Adam Lock]

r=dougt.

Thanks Doug, changes are checked in. Marking fixed.

Comment 5

[Michael Dunn]

Correction: Changing QA contact for the Embed API bugs to David Epstein.

Comment 6

[David Epstein]

changed QA contact to dsirnapalli. he's looking at this interface.

Comment 7

[dsirnapalli]

adam,did you remove asynchronous code or synchronous code because i see 
rv = inputChannel->AsyncOpen(this, nsnull); in nsWebbrowserPersist.cpp.

Comment 8

[Adam Lock]

The patch removed a bit of both. It removed the sync opening of the inputstream 
and the async opening of the output stream.

My comments were a bit confusing I know :)

Comment 9

[dsirnapalli]

marking bug as verified.