698285 - Please remove the two modal dialogs requirement for changing preferences

Status: RESOLVED WORKSFORME

(Toolkit :: Preferences, enhancement)

Description

[Alex Vincent [:WeirdAl]]

When I want to add a preference, I have to go through several steps:
(1) Right-click on the about:config page, select "New", and a type
(2) A modal dialog shows up, asking for a preference name.  I fill it in.
(3) Another modal dialog shows up, asking for the value.  I fill that in.

That's a lot of pain, when I could simply have a bar inside the page.  XUL pseudocode:

<toolbar>
  <toolbaritem>
    <label>Modify preference</label>
    <menulist editable="true" id="edit-prefname"><menupopup/></menulist>
    <menulist id="edit-preftype">
      <menupopup>
        <menuitem label="String"></menuitem>
        <menuitem label="Integer"></menuitem>
        <menuitem label="Boolean"></menuitem>
      </menupopup>
    </menulist>
  </toolbaritem>
  <label>Value</label>
  <deck>
    <toolbaritem>
      <textbox id="edit-prefvalue-string" size="20"/>
    </toolbaritem>
    <toolbaritem>
      <textbox type="number" id="edit-prefvalue-integer"/>
    </toolbaritem>
    <toolbaritem>
      <menulist id="edit-prefvalue-boolean">
        <menupopup>
          <menuitem label="false" value="0"/>
          <menuitem label="true"  value="1"/>
        </menupopup>
      </menulist>
    </toolbaritem>
  </deck>
  <toolbarbutton id="edit-pref-commit" label="Commit!"/>
</toolbar>

Of course, it's not quite that simple - several preferences-based tests (including code for bug 486407) would need to be rewritten.

Comment 1

[Alex Vincent [:WeirdAl]]

Maybe a checkbox too, saying "Prepend filter".

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This has nothing to do with bug 486407. Removing from blocking list.

Comment 3

[Gregory Pappas [:gregp]]

The about:config rewrite fixed this