Closed Bug 698311 Opened 9 years ago Closed 9 years ago

HTTP Auth dialog is not dismissible.

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: dougt, Assigned: wesj)

Details

Attachments

(1 file)

str:

1. load https://intranet.mozilla.org/
2. wait for username/password prompt
3. click cancel

expect:

not to be prompt again and see "Authorization Required" content

actual:

the username/password prompt reappears


Assign to wes for now since he implemented these dialogs.
Attached patch Patch v1Splinter Review
Two problems here. One came from select prompts. The code to build a list of "selected" items was returning an empty array regardless and breaking some "if (list == null)" checks. Fixed by returning a null list if not "selected" element is found.

Second, apparently BUTTON_POSITIVE has a value of -1, so my attempt to reuse the code in onClick when the user presses back to cancel was actually returning the "OK" result. Better to just build the result ourselves than try to outwit Android I guess.
Attachment #570733 - Flags: review?(mark.finkle)
Comment on attachment 570733 [details] [diff] [review]
Patch v1

Yay! for fast bug finds and fixes
Attachment #570733 - Flags: review?(mark.finkle) → review+
Wes - Make sure this doesn't break the other code that depends on the list prompt
http://hg.mozilla.org/projects/birch/rev/87f63a09a74e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified Fixed

20111101040211
http://hg.mozilla.org/projects/birch/rev/7203d86d5868
-- Samsung Galaxy SII (Android 2.3.4)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.