Closed Bug 698332 Opened 8 years ago Closed 8 years ago

Awesome bar needs a default text

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED

People

(Reporter: sriram, Assigned: sriram)

Details

Attachments

(1 file)

XUL based Fennec uses a default text of "Enter Search or Address" for browser toolbar and awesomebar. This is shown for "about:blank" and when adding a new tab. Native UI should use the same.
Assignee: nobody → sriram
OS: Mac OS X → Android
Hardware: x86 → ARM
Attached patch PatchSplinter Review
This added the strings to browser toolbar and awesomebar.
Attachment #570607 - Flags: review?(mark.finkle)
Comment on attachment 570607 [details] [diff] [review]
Patch


>diff --git a/embedding/android/resources/layout/browser_toolbar.xml b/embedding/android/resources/layout/browser_toolbar.xml

>+                android:text="@string/awesomebar_default_text"

When would this ever be seen? The hint used in the awesomebar_search I can see if I clear the text or open a new tab, but I can't find a way to see this usage. Let's drop it if we don't have a use case for it.

r+ but I am removing this use
This will be seen when Gecko is loading. My Nexus S with 50+ applications still takes 5 secs for the gecko to load. In such situations, the url button will have this text, which makes the user tap on it to enter a new search/url.
Comment on attachment 570607 [details] [diff] [review]
Patch

Sriram and I touched base on IRC. The browser_toolbar usage is for slow startups. I will switch it to a hint when I land it.
Attachment #570607 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/projects/birch/rev/d5da3bb90a1e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
20111103040334
http://hg.mozilla.org/projects/birch/rev/c09a52af4cd8
Samsung Nexus S (Android 2.3.6)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.