The default bug view has changed. See this FAQ.

"ASSERTION: Invalid offset" with bidi, -moz-column, :first-letter

RESOLVED FIXED in Firefox 12

Status

()

Core
Layout
--
critical
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: Jesse Ruderman, Assigned: smontagu)

Tracking

(Blocks: 2 bugs, 4 keywords)

Trunk
mozilla12
assertion, hang, regression, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox9 affected, firefox10 affected, firefox11 affected, firefox12 verified, status1.9.2 unaffected)

Details

(Whiteboard: [qa+])

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Created attachment 570608 [details]
testcase (hangs Firefox)

###!!! ASSERTION: Invalid offset: 'aOffset <= mSkipChars->mCharCount', file gfx/thebes/gfxSkipChars.cpp, line 92

###!!! ASSERTION: Text run does not map enough text for our reflow: 'gfxSkipCharsIterator(iter).ConvertOriginalToSkipped(offset + length) <= mTextRun->GetLength()', file layout/generic/nsTextFrameThebes.cpp, line 7109

###!!! ASSERTION: Invalid offset: 'aOffset <= mSkipChars->mCharCount', file gfx/thebes/gfxSkipChars.cpp, line 92

###!!! ASSERTION: unconstrained height on totally empty line: 'NS_UNCONSTRAINEDSIZE != aFloatAvailableSpace.mRect.height', file layout/generic/nsBlockFrame.cpp, line 3686

###!!! ASSERTION: redo line on totally empty line with non-empty band...: 'aFloatAvailableSpace.mHasFloats', file layout/generic/nsBlockFrame.cpp, line 3691
(Reporter)

Comment 1

6 years ago
Created attachment 570609 [details]
stack traces
Is this exploitable or just a DoS/hang? would more/fewer/different characters change the symptoms?
Assignee: nobody → smontagu
smontagu - any update here?
(Assignee)

Comment 4

5 years ago
Created attachment 588753 [details] [diff] [review]
Patch

This is apparently regression from making a preformatted newline a new bidi paragraph: we need to test whether there are any fluid continuations even beyond the current paragraph, but children of the same block element and convert them to non-fluid.
Attachment #588753 - Flags: review?(roc)
Attachment #588753 - Flags: review?(roc) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/60add44419ef
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla12
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/60add44419ef
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Do we need to land this on Aurora as a security bug or did it turn out benign and we can unhide the bug? If it really is a potentially sg:critical bug we maybe shouldn't have called it out in the Platform meeting, especially with a checked-in crashtest.
status1.9.2: --- → unaffected
status-firefox10: --- → affected
status-firefox11: --- → affected
status-firefox12: --- → fixed
Keywords: regression, regressionwindow-wanted
(Assignee)

Comment 8

5 years ago
Regression window is http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a666b4f809f0&tochange=953f9620f395, which is not what I expected: possibly bug 578977?
Keywords: regressionwindow-wanted
(Assignee)

Comment 9

5 years ago
Comment on attachment 588753 [details] [diff] [review]
Patch

This doesn't seem exploitable to me, but since we have a simple patch let's fix it on aurora and beta.

[Approval Request Comment]
Regression caused by (bug #): 578977(? see comment 8)
User impact if declined: hangs and possible crashes
Testing completed (on m-c, etc.): baked 6 days on m-c, has crashtest.
Risk to taking this patch (and alternatives if risky): minimal.
Attachment #588753 - Flags: approval-mozilla-beta?
Attachment #588753 - Flags: approval-mozilla-aurora?
(In reply to Simon Montagu from comment #8)
> possibly bug 578977?

Confirmed by reverting bug 578977 in an Aurora debug build on Linux.
Bug 578977 did change some things that affects next-in-flows of first-letter
frames, so it makes sense.
Blocks: 578977
status-firefox9: --- → affected
given comment 9 I think we can hold off on this given timing for 10. But we should be able to land this on Aurora, we can cover that in the next triage/channel mtg.
Comment on attachment 588753 [details] [diff] [review]
Patch

[Triage Comment]
We don't have any evidence that this is exploitable or causing significant user pain - let's let this ride the train.
Attachment #588753 - Flags: approval-mozilla-beta?
Attachment #588753 - Flags: approval-mozilla-beta-
Attachment #588753 - Flags: approval-mozilla-aurora?
Attachment #588753 - Flags: approval-mozilla-aurora-
Group: core-security
Whiteboard: [qa+]
Verified using linux debug build on Ubuntu 11.10 with beta debug build (18.4.2012)- no hang/assertion when loading the test case from comment 0.
status-firefox12: fixed → verified
Depends on: 989994
You need to log in before you can comment on or make changes to this bug.