698344 - Configure.in for Firefox 8 beta requires only NSS 3.12.10 but we only have test coverage for NSS 3.12.11

Status: RESOLVED WORKSFORME

(Core :: Security: PSM, defect, P1)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

+++ This bug was initially created as a clone of Bug #698342 +++
+++ This bug was initially created as a clone of Bug #673382 +++

When we upgraded mozilla-central to NSS 3.12.11, we didn't change configure.in to require NSS 3.12.11. We have no (automated) testing for Firefox 8+with earlier versions, so we need to require NSS 3.12.11 when using system NSS.

This has a material effect only on Linux, AFAICT.

This won't affect mozilla-aurora or mozilla-central, because both of those are already requiring a newer version of NSS (NSS 3.13.1).

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Require NSS 3.12.11 or later when using system NSS

Requesting approval for mozilla-beta. See description for more details.

Comment 2

[Mike Hommey [:glandium]]

(In reply to Brian Smith (:bsmith) from comment #0)
> This won't affect mozilla-aurora or mozilla-central, because both of those
> are already requiring a newer version of NSS (NSS 3.13.1).

Are you sure about this? I built aurora against a system NSS 3.12.11 without any complaint on friday.

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to Mike Hommey [:glandium] from comment #2)
> (In reply to Brian Smith (:bsmith) from comment #0)
> > This won't affect mozilla-aurora or mozilla-central, because both of those
> > are already requiring a newer version of NSS (NSS 3.13.1).
> 
> Are you sure about this? I built aurora against a system NSS 3.12.11 without
> any complaint on friday.

The same bug affects -aurora and -central currently but once we land the patches in bug 669061, both of them will require system NSS 3.13.1. So, we don't need to land anything in -central or -aurora for this bug.

Comment 4

[Alex Keybl [:akeybl]]

Comment on attachment 570617 [details] [diff] [review]
Require NSS 3.12.11 or later when using system NSS

[Triage Comment]
* Minusing approval-mozilla-beta as we've already built what we hope to be our RC, and this does not seem critical enough to re-roll

Comment 5

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

At a minimum, QA should sign off that they have tested Firefox 8 on Linux using system NSS 3.12.10 and not a later version. AFAICT, we have had no testing at all in this configuration.

Comment 6

[(not currently active) Ted Mielczarek]

Why is that necessary? If we've tested what we're shipping, then that should be sufficient. If we're relying on new features in NSS 3.12.11, then we should bump the version requirement.

Comment 7

[Wan-Teh Chang]

Comment on attachment 570617 [details] [diff] [review]
Require NSS 3.12.11 or later when using system NSS

r=wtc.

I suggest we check in this patch in mozilla-central, or
mark the bug WONTFIX.  We should not leave the bug open
indefinitely.

Comment 8

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

configure.in now requires NSPR 4.9 and NSS 3.13.2.