698522 - Google Maps API key throwing error on geolocation page

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Rubin110]

Attachment: Screenshot of window

Steps to produce:
1. Open a web browser (in this case Firefox 7.0.1 from the Debian Sid repo)
2. Load up https://www.mozilla.org/en-US/firefox/geolocation/
3. Observe

Expected results:
Page loads and displays content

Actual results:
Page loads then displays a Google Maps API error...

"This web site needs a different Google Maps API key. A new key can be generated at http://code.google.com/apis/maps/signup.html."

If there is an embedded Google Map in this page, it's not displayed. Please see attached screen shot.

Notes:
A current version of Chromium doesn't display the error, additionally it complains about resources on the page not being passed through SSL when getting the HTTPS version of the page.

Comment 1

[Tom Lowenthal]

If this error is only occurring in FF, isn't it potentially a browser rather than a site problem?

Comment 2

[Anthony Ricaud (:rik)]

Thanks for the report. This has been fixed in another bug already.

Comment 4

[Mike Kaply [:mkaply]]

This seems to have started happening again in Chrome and Firefox.

What bug supposedly fixed this?

Comment 5

[raymond [:retornam] (inactive)]

confirmed this is happening on prod.

Comment 6

[Hector Zhao [:hectorz]]

Google Maps API v3 uses different key from v2[1], v3 is introduced by this PR[2].

[1]: https://developers.google.com/maps/documentation/javascript/tutorial#api_key
[2]: https://github.com/mozilla/bedrock/pull/160

Comment 7

[Anthony Ricaud (:rik)]

I'm gonna put this on hold to see how we're supposed to get this new key. Since you have to accept terms of services and there is some billing involved.

Comment 8

[chris hofmann]

we link directly to this page in the product (firefox) and it looks like user might hit this page when following the link off the warning bar that is presented when a page requests localtion info.

 so we should probably get it fixed sooner rather than latter.

browser.geolocation.warning.infoURL

http://mxr.mozilla.org/mozilla-central/search?string=browser.geolocation.warning.infoURL&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Comment 9

[Anthony Ricaud (:rik)]

So I reverted the change to the V3 API and I'm asking for a push to fix this.

Hector: Sorry for this. We'll track the new key issue with bug 767767.

Comment 10

[Anthony Ricaud (:rik)]

Oh and the revert commit is https://github.com/mozilla/bedrock/commit/f83d63759590e828a63ee32408f366cdbd3fbf25

Comment 11

[Hector Zhao [:hectorz]]

(In reply to Anthony Ricaud (:rik) from comment #9)
> So I reverted the change to the V3 API and I'm asking for a push to fix this.
> 
> Hector: Sorry for this. We'll track the new key issue with bug 767767.

Keep the site working normally is more important.

I under-estimated the efforts required to get this new key, sorry for not mentioning this in the original PR.

Comment 12

[Anthony Ricaud (:rik)]

Fix deployed.

Comment 13

[raymond [:retornam] (inactive)]

verified fixed https://www.mozilla.org/en-US/firefox/geolocation/