Last Comment Bug 698526 - toolkit/toolkit-makefiles.sh: typo -- add_makefile not found
: toolkit/toolkit-makefiles.sh: typo -- add_makefile not found
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla10
Assigned To: Ed Morley [:emorley]
:
Mentors:
Depends on:
Blocks: 683229
  Show dependency treegraph
 
Reported: 2011-10-31 11:43 PDT by Joey Armstrong [:joey]
Modified: 2011-11-01 07:36 PDT (History)
2 users (show)
emorley: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Fix typo in toolkit-makefiles.sh (723 bytes, patch)
2011-10-31 13:23 PDT, Ed Morley [:emorley]
emorley: checkin+
Details | Diff | Splinter Review

Description Joey Armstrong [:joey] 2011-10-31 11:43:05 PDT
builder: try-linux64
slave: linux64-ix-slave23
starttime: 1320082111.65
results: success (0)
buildid: 20111031102851
builduid: cc5c0ce28baa416b928774f932b39fe4
revision: 750e2e584e10

/builds/slave/try-lnx64/build/toolkit/toolkit-makefiles.sh: line 1064: add_makefile: command not found

Try job reported success on linux.  allmakefiles.sh should set 'sh -e errexit' if not already set and pay attention to exit status.
Comment 1 Joey Armstrong [:joey] 2011-10-31 11:50:10 PDT
configure.in is not checking shell exit status after calling allmakefiles.sh
Comment 2 Ed Morley [:emorley] 2011-10-31 13:23:39 PDT
Created attachment 570823 [details] [diff] [review]
Fix typo in toolkit-makefiles.sh

Given rs+ by ted in #pymake.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b6a3f81fc029
Comment 3 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-11-01 07:36:47 PDT
https://hg.mozilla.org/mozilla-central/rev/b6a3f81fc029

Note You need to log in before you can comment on or make changes to this bug.