698771 - With <button type="checkbox"/>, hitting space toggles the state and calls oncommand, but hitting enter just calls oncommand

Status: NEW

(Core :: XUL, defect)

Description

[Thomas D. (:thomas8)]

Nitfix required:

STR

1) view mail with attachments
2) press <tab> until focusring is on the [+] twisty (due to the unbelievable saga of bug 647036, attachment pane will be collapsed by default regardless of your use patterns)
3) press <enter>
4) press <space>

5) press <shift>+<tab> (focusring back on [-] twisty)
6) press <enter>

Actual result

3) <enter> on [+] twisty does nothing (wrong)
4) <space> on [+] twisty shows attachment pane and moves focus ring to first attachment (intended)
6) <enter> on [-] twisty does NOT hide attachment pane, moves focus ring to first attachment instead (wrong)

Expected result

3) <enter> on focused [+] twisty should do the same as <space>, i.e.
show attachment pane and move focus ring to first attachment
6) <enter> on [-] twisty should hide attachment pane (and perhaps move focus ring to body text element, as we do for mouse click)

Comment 1

[Jim Porter (:squib)]

This is a core bug with the <button type="checkbox"/> widget. Updating as such.

Steps to reproduce this:

1) Create a button like so:
   <button type="checkbox" oncommand="alert(this.checked)"/>
2) Focus the button and hit space a few times; note that the checked state toggles and the
   command fires each time
3) Now hit enter a few times; note that the command fires but the checked state stays the
   same