698790 - test_driver.js is skipped in mutt tests because the driver module is broken

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Jeff Hammel]

(mozmill)│mozmill -t test_driver.js 
Xlib:  extension "GLX" missing on display ":0.0".
TEST-START | test_driver.js | setupModule
ERROR | Test Failure: {"exception": {"stack":
"getTopmostWindowByType(\"navigator:browser\",false)@resource://mozmill/stdlib/securable-module.js
->
resource://mozmill/modules/driver.js:296\ngetBrowserWindow()@resource://mozmill/stdlib/securable-module.js
-> resource://mozmill/modules/driver.js:66\n", "message": "services is
not defined", "fileName":
"resource://mozmill/stdlib/securable-module.js ->
resource://mozmill/modules/driver.js", "name": "ReferenceError",
"lineNumber": 296}}
TEST-START | test_driver.js | testDriver
INFO | Test Skipped: "setupModule failed."
WARNING | testDriver | (SKIP) setupModule failed.
ERROR | Test Failure: {"message": "[JavaScript Error:
\"ReferenceError: services is not defined\" {file:
\"resource://mozmill/modules/frame.js\" line: 552}]"}
INFO | Timeout:
bridge.execFunction("37e5229a-04ad-11e1-9f54-00262df16844",
bridge.registry["{185a4a90-ec6f-4b86-8f2d-d88f4e4ff7e1}"]["cleanQuit"],
[])
INFO | 
INFO | Passed: 0
INFO | Failed: 0
INFO | Skipped: 1

This is not reported as failing due to bug 698769

Comment 1

[Jeff Hammel]

So here is the culprit:

https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/extension/resource/modules/driver.js#L296

We never define services.  Any insight as to what should actually be happening here?

Comment 2

[Jeff Hammel]

11:08 < whimboo1> jhammel: loosk like we have a refrence to the services module 
                  which is part of our API rewrite but has not been checked in

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Just remove the services. prefix. wm gets already defined here:

https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/extension/resource/modules/driver.js#L47

Comment 4

[Jeff Hammel]

following comment 3, i get

(mozmill)│mozmill -t mutt/mutt/tests/js/test_driver.js 
Xlib:  extension "GLX" missing on display ":0.0".
TEST-START | mutt/mutt/tests/js/test_driver.js | setupModule
TEST-START | mutt/mutt/tests/js/test_driver.js | testDriver
ERROR | Test Failure: {"exception": {"stack": "notEqual([object Proxy],null,\"A browser window has been found\")@resource://mozmill/stdlib/securable-module.js -> resource://mozmill/modules/assertions.js:319\n", "message": "cyclic object value", "fileName": "resource://mozmill/stdlib/securable-module.js -> resource://mozmill/modules/assertions.js", "name": "TypeError", "lineNumber": 319}}
TEST-UNEXPECTED-FAIL | mutt/mutt/tests/js/test_driver.js | testDriver
ERROR | Test Failure: {"message": "[JavaScript Error: \"TypeError: cyclic object value\" {file: \"resource://mozmill/modules/frame.js\" line: 552}]"}
INFO | Timeout: bridge.execFunction("bbd959aa-04b6-11e1-8a48-00262df16844", bridge.registry["{b7f2db8c-cd31-48ea-990b-4b2f236478ee}"]["cleanQuit"], [])
INFO | 
INFO | Passed: 0
INFO | Failed: 1
INFO | Skipped: 0

Comment 5

[Jeff Hammel]

Following the fix of 698865, I get:

(mozmill)│mozmill -t mutt/mutt/tests/js/test_driver.js 
Xlib:  extension "GLX" missing on display ":0.0".
TEST-START | mutt/mutt/tests/js/test_driver.js | setupModule
TEST-START | mutt/mutt/tests/js/test_driver.js | testDriver
INFO | Step Pass: {"pass": {"function": "Expect__test", "message": "A browser window has been found - '[object ChromeWindow]' should not equal 'null'", "lineNumber": 46, "stack": {"caller": {"caller": {"caller": {"caller": {"caller": {"caller": {"caller": {"caller": {"caller": {"caller": {"caller": {"caller": null, "name": null, "language": 2, "sourceLine": null, "languageName": "JavaScript", "filename": "resource://jsbridge/modules/nspr-server.js", "lineNumber": 59}, "name": null, "language": 1, "sourceLine": null, "languageName": "C++", "filename": null, "lineNumber": 0}, "name": null, "language": 2, "sourceLine": null, "languageName": "JavaScript", "filename": "resource://jsbridge/modules/bridge.js", "lineNumber": 139}, "name": null, "language": 2, "sourceLine": null, "languageName": "JavaScript", "filename": "resource://jsbridge/modules/bridge.js", "lineNumber": 135}, "name": null, "language": 2, "sourceLine": null, "languageName": "JavaScript", "filename": "resource://mozmill/modules/frame.js", "lineNumber": 607}, "name": null, "language": 2, "sourceLine": null, "languageName": "JavaScript", "filename": "resource://mozmill/modules/frame.js", "lineNumber": 504}, "name": null, "language": 2, "sourceLine": null, "languageName": "JavaScript", "filename": "resource://mozmill/modules/frame.js", "lineNumber": 581}, "name": null, "language": 2, "sourceLine": null, "languageName": "JavaScript", "filename": "resource://mozmill/modules/frame.js", "lineNumber": 536}, "name": "testDriver", "language": 2, "sourceLine": null, "languageName": "JavaScript", "filename": "resource://mozmill/modules/frame.js -> file:///home/jhammel/mozmill/src/mozmill/mutt/mutt/tests/js/test_driver.js", "lineNumber": 46}, "name": null, "language": 1, "sourceLine": null, "languageName": "C++", "filename": null, "lineNumber": 0}, "name": "notEqual", "language": 2, "sourceLine": null, "languageName": "JavaScript", "filename": "resource://mozmill/stdlib/securable-module.js -> resource://mozmill/modules/assertions.js", "lineNumber": 333}, "name": "Expect__test", "language": 2, "sourceLine": null, "languageName": "JavaScript", "filename": "resource://mozmill/stdlib/securable-module.js -> resource://mozmill/modules/assertions.js", "lineNumber": 237}, "fileName": "file:///home/jhammel/mozmill/src/mozmill/mutt/mutt/tests/js/test_driver.js"}}
ERROR | Test Failure: {"exception": {"stack": "openBrowserWindow()@resource://mozmill/stdlib/securable-module.js -> resource://mozmill/modules/driver.js:100\n", "message": "mozmill is not defined", "fileName": "resource://mozmill/stdlib/securable-module.js -> resource://mozmill/modules/driver.js", "name": "ReferenceError", "lineNumber": 100}}
TEST-UNEXPECTED-FAIL | mutt/mutt/tests/js/test_driver.js | testDriver
ERROR | Test Failure: {"message": "[JavaScript Error: \"ReferenceError: mozmill is not defined\" {file: \"resource://mozmill/modules/frame.js\" line: 552}]"}