use signed updater.exe for elm and oak branches

RESOLVED FIXED

Status

RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

bug 696777 lets us inject an already signed updater.exe into a new build. We need to enable this for the elm and oak twigs, which are being used for bug 481815. Basically, we need to set MOCO_SIGNED_UPDATER_EXE to an URL that points to the signed updater.exe.
Created attachment 571131 [details] [diff] [review]
merge environments instead of overwriting; set MOZ_SIGNED_UPDATER_EXE for elm and oak

Lukas, what do you think of merging project branch environments instead of overwriting them?
Attachment #571131 - Flags: review?(lsblakk)
Attachment #571131 - Flags: review?(lsblakk) → review+
(Assignee)

Updated

7 years ago
Attachment #571131 - Flags: checked-in+
Any ETA on this landing?
This already landed. It won't take effect until elm and oak get https://bugzilla.mozilla.org/show_bug.cgi?id=696777.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
nice! So it seems I can use bug 696777 on elm as of today if I push the unreviewed patch right? I'll just re-push any changes that it gets after review.
(In reply to Brian R. Bondy [:bbondy] from comment #4)
> nice! So it seems I can use bug 696777 on elm as of today if I push the
> unreviewed patch right? I'll just re-push any changes that it gets after
> review.

You're welcome to try. I take no responsibility for any damage though ;)
This isn't working for some reason.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Presumably because this patch uses MOZ_SIGNED_UPDATER_EXE and the build system patch uses MOCO_SIGNED_UPDATER_EXE?
Ah, it looks like the only problem here is that there hasn't been an update to the production buildbots since I landed this patch. I'll make sure that happens today.(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #7)
> Presumably because this patch uses MOZ_SIGNED_UPDATER_EXE and the build
> system patch uses MOCO_SIGNED_UPDATER_EXE?

*facepalm*. Yes, that. But I also noticed that this never made its way to the production buildbots. I landed a fix in http://hg.mozilla.org/build/buildbot-configs/rev/d00364ebead8, and there will be a reconfig at some point today to pick it up.

Comment 9

7 years ago
This went live at 8:45 AM PDT.
Ready for me to retry?
(In reply to Brian R. Bondy [:bbondy] from comment #10)
> Ready for me to retry?

Yup!
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
The path to this got changed a bit with a patch in bug 696777.
Depends on: 696777
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.