698865 - notEqual fails if JSON.stringify encounters cycle objects

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Jeff Hammel]

see https://bugzilla.mozilla.org/show_bug.cgi?id=698790#c4

ERROR | Test Failure: {"exception": {"stack": "notEqual([object
Proxy],null,\"A browser window has been
found\")@resource://mozmill/stdlib/securable-module.js ->
resource://mozmill/modules/assertions.js:319\n", "message": "cyclic
object value", "fileName":
"resource://mozmill/stdlib/securable-module.js ->
resource://mozmill/modules/assertions.js", "name": "TypeError",
"lineNumber": 319}}

caused by the call in assertions.js calling JSON.stringify on cyclic objects

Comment 1

[Jeff Hammel]

fixed on master: https://github.com/mozautomation/mozmill/commit/af726ea30723fe31d7c16cf8688ed81635206729

If there is a reason/need to fix on 2.0 please reopen.

Comment 2

[Jeff Hammel]

This needs to be fixed in 2.0 too

Comment 3

[Jeff Hammel]

Attachment: fix for hotfix-2.0

Comment 4

[Andrew Halberstadt [:ahal]]

Comment on attachment 571390 [details] [diff] [review]
fix for hotfix-2.0

Review of attachment 571390 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r+ assuming it's been tested.

Comment 5

[Jeff Hammel]

pushed: https://github.com/mozautomation/mozmill/commit/8a420790250a968096e9f03adf32ed20b10d8bed

And yes, its been tested.  There will only be a few more patches and the mutt tests will actually pass!