Closed
Bug 698872
Opened 13 years ago
Closed 13 years ago
driver.js references mozmill; this is undefined
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: k0scist, Unassigned)
References
Details
(Whiteboard: [mozmill-2.0+])
Attachments
(1 file)
|
655 bytes,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/extension/resource/modules/driver.js#L100 We reference mozmill but we never import it. Seriously?
|
Reporter | |
Comment 1•13 years ago
|
||
pushed to master: https://github.com/mozautomation/mozmill/commit/c6cc6d691e8c9c8a7ed7aca8000cf170ddc6497e
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 2•13 years ago
|
||
Still an issue with 2.0
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Reporter | |
Comment 3•13 years ago
|
||
Attachment #576028 -
Flags: review?(ahalberstadt)
|
|
Reporter | |
Comment 4•13 years ago
|
||
I'm still getting cleanQuit errors even with the patch:
(mozmill-2.0)│mozmill -t test_driver.js
INFO | Timeout: bridge.execFunction("3b45716a-14a2-11e1-a9a6-00262df16844", bridge.registry["{fe7e0526-4620-49e2-a9e4-101820812d02}"]["cleanQuit"], [])
INFO |
INFO | Passed: 0
INFO | Failed: 0
INFO | Skipped: 0|
|
Reporter | |
Comment 5•13 years ago
|
||
Notice also that I get zero results: no passes, no fails, no skipped.
|
|
Reporter | |
Comment 6•13 years ago
|
||
comment 4 and comment 5 are bug 696468 and should probably be ignored for the purpose of landing
|
|
Reporter | |
Updated•13 years ago
|
Whiteboard: [mozmill-2.0+]
|
||
Comment 7•13 years ago
|
||
Comment on attachment 576028 [details] [diff] [review] port to hotfix-2.0 Review of attachment 576028 [details] [diff] [review]: ----------------------------------------------------------------- Good catch, r+
Attachment #576028 -
Flags: review?(ahalberstadt) → review+
|
|
Reporter | |
Comment 8•13 years ago
|
||
pushed: https://github.com/mozautomation/mozmill/commit/b40e6f84b6778258dce143ecd9ad3318ccb89a05
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
|
Assignee | |
Updated•8 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•