Invitations Dialog: Selected option is not totally obvious

RESOLVED FIXED in 1.0

Status

defect
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

unspecified
x86
macOS
Bug Flags:
blocking-calendar1.0 +

Details

(Whiteboard: [needed beta][no l10n impact])

Attachments

(1 attachment)

Posted patch Fix - v1 โ€” โ€” Splinter Review
When accepting an invitation, the icon to the left is changed, but nothing happens to the buttons. This can be a bit confusing. This patch gives the buttons a checkbox style, so they are pressed when selected.

Mac made this patch really annoying, since there is no different button style. Misusing the -moz-apperance: tab works though.

If possible I'd like to take this for 1.0 to round off corners.

To test this patch you need a server that supports server side invitations (like sogo-demo.inverse.ca), send yourself an invitations, then click on the invitations checkbox in the status bar.
Attachment #571181 - Flags: review?(bv1578)
Flags: blocking-calendar1.0+
Pushed to comm-central changeset 1e91922620ba
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Trunk
Backported to releases/comm-aurora changeset e3a8ca5a6614
Target Milestone: Trunk → 1.0b9
Backported to releases/comm-beta changeset faca33ff533f
Target Milestone: 1.0b9 → 1.0b8
Comment on attachment 571181 [details] [diff] [review]
Fix - v1

Clearing review flag as this is a patch which has been checked in one year ago.
Attachment #571181 - Flags: review?(bv1578)
You need to log in before you can comment on or make changes to this bug.