699043 - Let admins remove admin flag when submitting a review

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[Andrew Williamson [:eviljeff]]

The majority of times a super review request is only applicable for a single version yet the flag stays unless someone goes into the /flagged page and specifically removes it.

This means a number of add-ons are unnecessarily ignored by non-admin editors.

I envision a checkbox under the 'notify' checkbox that can be selected to remove the admin flag at the same time as the review is processed.  If we just want to remove the admin flag and not process the review it wouldn't hurt us to have to add use the 'comment' option.

I'm not sure whether we want it to be a 'keep the flag' or 'clear the flag' checkbox and whether it should be ignored for the super review option.

Ideally it would only be shown when the user is an admin and the add-on is already flagged but always being shown and then silently failing to change the status on submit would be acceptable given the audience, IMO.

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

(In reply to Andrew Williamson [:eviljeff] from comment #0)
> I'm not sure whether we want it to be a 'keep the flag' or 'clear the flag'
> checkbox and whether it should be ignored for the super review option.

I think "Remove admin flag", unchecked by default would be good. The checkbox should only appear when the add-on has been flagged and the user is an admin.

Comment 2

[Andrew Williamson [:eviljeff]]

https://github.com/mozilla/zamboni/pull/265

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...

Comment 4

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/cb9a2d7

Comment 5

[krupa raj[:krupa]]

verified fixed at https://addons-dev.allizom.org/en-US/editors/review/wwwtran?num=8

Comment 6

[krupa raj[:krupa]]

Attachment: post-fix screenshot