Uploading dowloaded minified jquery file causes unicode error

RESOLVED FIXED in Builder 1.0

Status

addons.mozilla.org Graveyard
Add-on Builder
P1
major
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: canuckistani, Assigned: zalun)

Tracking

unspecified
Builder 1.0
x86
Mac OS X

Details

Attachments

(1 attachment)

Created attachment 571418 [details]
error from upload

If I try to add the  current release of jQuery to my project by url:

http://code.jquery.com/jquery-1.6.4.min.js

...I get an error ( see attached screenshot ).
Piotr, let's get this and the rest of the unicode issues taken care of as soon as possible.
Assignee: nobody → zaloon
Severity: normal → major
Priority: -- → P1
Target Milestone: --- → Builder 1.0
(Assignee)

Comment 2

6 years ago
https://github.com/mozilla/FlightDeck/pull/73
Status: NEW → ASSIGNED
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
I still see this, or it's come back. Trying to attach the minified jQuery, for example: http://code.jquery.com/jquery-1.7.1.min.js, I see the same error:

***
Error 403

FORBIDDEN
'Attachment failed to save properly
Unknown Unicode in file'
***
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

5 years ago
It is working fine
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago5 years ago
Resolution: --- → WORKSFORME
It reliably does not work for me.

* jQuery.min downloaded from http://code.jquery.com/jquery-1.7.2.min.js
* Mac OS X 10.6.8
* Firefox 13

I've tried with a clean profile, same problem.

This has been reported elsewhere since this bug was closed, for example:
http://stackoverflow.com/questions/9769108/unable-to-upload-jquery-1-7-1-min-for-firefox-addon-using-addon-builder
https://forums.mozilla.org/addons/viewtopic.php?p=11257&sid=2e7016d0aed3457c9243ba33fd6fc950
(Assignee)

Comment 6

5 years ago
There is indeed an error if file was downloaded an then uploaded.
Adding the file by providing its URL is working fine.
The description is about the latter which was fixed, that's why I marked it as resolved.

STR:

1. download http://code.jquery.com/jquery-1.7.2.min.js
2. open add attachent modal
3. select the file from disk and submit the form
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Summary: minified jquery library upload causes unicode error → Uploading dowloaded minified jquery file causes unicode error
(Assignee)

Comment 7

5 years ago
In review https://github.com/mozilla/FlightDeck/pull/155
Status: REOPENED → ASSIGNED
(Assignee)

Comment 8

5 years ago
on master
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.