699243 - Bridge necessary Android accessibility functions to Gecko.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P4)

Description

[Eitan Isaacson [:eeejay]]

We will need some Android platform functions inside Gecko. Specifically, we need to be able to know if accessibility in Android is enabled so we could instantiate accessibility. We also need a method of relaying accessibility events to the Android platform.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Add method to GeckoAppShell to check for a11y and bridge it

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Instantiate a11y if Android a11y is turned on

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Add method to GeckoAppShell to emit a11y events and bridge it

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 571474 [details] [diff] [review]
Instantiate a11y if Android a11y is turned on

Review of attachment 571474 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/src/android/nsWindow.h
@@ +232,5 @@
> +    /**
> +     * Generate the NS_GETACCESSIBLE event to get accessible for this window
> +     * and return it.
> +     */
> +    nsAccessible       *DispatchAccessibleEvent();

nit, nsAccessible* DispatchAccessibleEvent();

Also, there are tabs in this patch, get rid of them

Comment 5

[Eitan Isaacson [:eeejay]]

Attachment: Instantiate a11y if Android a11y is turned on

I think this fixes the whitespace issues, didn't find any tabs.

Comment 6

[Eitan Isaacson [:eeejay]]

I don't have commit access :) could someone please push these?

Comment 7

[Kevin Brosnan [Ex-Mozilla]]

There is a checkin-needed keyword for that. Though you need to set up your .hgrc to add author info to the patch (http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed), and reattach an updated patch with author and commit message.

Comment 8

[Eitan Isaacson [:eeejay]]

Attachment: Add method to GeckoAppShell to check for a11y and bridge it

Comment 9

[Eitan Isaacson [:eeejay]]

Attachment: Instantiate a11y if Android a11y is turned on

Comment 10

[Eitan Isaacson [:eeejay]]

Attachment: Add method to GeckoAppShell to emit a11y events and bridge it

Comment 11

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/projects/birch/rev/e2dc4acd3a68
https://hg.mozilla.org/projects/birch/rev/7b2dd926316c
https://hg.mozilla.org/projects/birch/rev/2d86eea1a4cb

Comment 12

[Wesley Johnston (:wesj)]

These patches were backed while investigating Talos failures.  Now that tests are green again, we will need to reland.

Comment 13

[Eitan Isaacson [:eeejay]]

Don't have write access, could someone please land these?

Comment 14

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to Wesley Johnston (:wesj) from comment #12)
> These patches were backed while investigating Talos failures.

What kind of failures?

Comment 15

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to David Bolter [:davidb] from comment #14)
> (In reply to Wesley Johnston (:wesj) from comment #12)
> > These patches were backed while investigating Talos failures.
> 
> What kind of failures?

talos

backout was backed out https://hg.mozilla.org/projects/birch/rev/6f925b45a547