Closed Bug 699243 Opened 11 years ago Closed 11 years ago

Bridge necessary Android accessibility functions to Gecko.

Categories

(Firefox for Android Graveyard :: General, defect, P4)

ARM
Android
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: eeejay, Assigned: eeejay)

Details

(Whiteboard: birch)

Attachments

(3 files, 4 obsolete files)

We will need some Android platform functions inside Gecko. Specifically, we need to be able to know if accessibility in Android is enabled so we could instantiate accessibility. We also need a method of relaying accessibility events to the Android platform.
Attachment #571471 - Flags: review?(mark.finkle)
Assignee: nobody → eitan
Attachment #571474 - Flags: review?(mark.finkle)
Attachment #571478 - Flags: review?(mark.finkle)
Attachment #571471 - Flags: review?(mark.finkle) → review?(blassey.bugs)
Attachment #571474 - Flags: review?(mark.finkle) → review?(blassey.bugs)
Attachment #571478 - Flags: review?(mark.finkle) → review?(blassey.bugs)
Priority: -- → P4
Attachment #571471 - Flags: review?(blassey.bugs) → review+
Comment on attachment 571474 [details] [diff] [review]
Instantiate a11y if Android a11y is turned on

Review of attachment 571474 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/src/android/nsWindow.h
@@ +232,5 @@
> +    /**
> +     * Generate the NS_GETACCESSIBLE event to get accessible for this window
> +     * and return it.
> +     */
> +    nsAccessible       *DispatchAccessibleEvent();

nit, nsAccessible* DispatchAccessibleEvent();

Also, there are tabs in this patch, get rid of them
Attachment #571474 - Flags: review?(blassey.bugs) → review+
Attachment #571478 - Flags: review?(blassey.bugs) → review+
OS: Linux → Android
Hardware: x86_64 → ARM
I think this fixes the whitespace issues, didn't find any tabs.
Attachment #571474 - Attachment is obsolete: true
I don't have commit access :) could someone please push these?
There is a checkin-needed keyword for that. Though you need to set up your .hgrc to add author info to the patch (http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed), and reattach an updated patch with author and commit message.
Attachment #571471 - Attachment is obsolete: true
Attachment #571955 - Flags: review+
Attachment #571820 - Attachment is obsolete: true
Attachment #571957 - Flags: review+
Attachment #571955 - Flags: review+
Attachment #571957 - Flags: review+
Attachment #571958 - Flags: review+
Whiteboard: checkin-needed birch
These patches were backed while investigating Talos failures.  Now that tests are green again, we will need to reland.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Don't have write access, could someone please land these?
Keywords: checkin-needed
Whiteboard: birch
(In reply to Wesley Johnston (:wesj) from comment #12)
> These patches were backed while investigating Talos failures.

What kind of failures?
(In reply to David Bolter [:davidb] from comment #14)
> (In reply to Wesley Johnston (:wesj) from comment #12)
> > These patches were backed while investigating Talos failures.
> 
> What kind of failures?

talos

backout was backed out https://hg.mozilla.org/projects/birch/rev/6f925b45a547
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.