699278 - Quotes in app name cause corrupt installation

Status: VERIFIED FIXED

(Web Apps :: Extension, defect, P2)

Description

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

This may happen with other characters as well, but it's definitely happening with the app "Dave's Galaxy"

Comment 1

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Quotes are no longer a problem in the feature/native-app branch as of this commit:
https://github.com/mozilla/openwebapps/commit/045086aa2c883f44d2d394e5185a3412994f4e68

We do need to sanitize app names to combat malicious manifests, but that will be filed as a separate bug.

Please reopen if quotes become an issue again

Comment 2

[Mohamed Dabbagh]

How can QA verify this fix? Do we just install the app 'Dave's Galaxy' and make sure that a native install happens properly?

Comment 3

[Tim Abraldes [:TimAbraldes] [:tabraldes]]

Installing "Dave's Galaxy" and verifying that the install succeeds sounds sufficient to me.  If we discover that quotes in other app names are causing problems we can reopen this bug.

We also have bug 704574 for sanitizing manifest values.

Comment 4

[Mohamed Dabbagh]

Tested using FF 9b4 with openwebapps-5761c50c73-12_08_2011.xpi from http://people.mozilla.com/~dclarke/openwebapps/Extension/. Tried with Dave's Galaxy and with "Buckaroo" Bob's Cool App (steps for getting the app from bug 704574) on Windows 7, XP, Vista and using Dave's Galaxy on Mac 10.7.2 and the installations were successful. The correct app icon was shown (except for XP which is a known bug) and I was able to launch the app as well.