[/m fix for tablet] Change the download button to serve different download via user agent

VERIFIED FIXED in 4.11

Status

VERIFIED FIXED
7 years ago
6 years ago

People

(Reporter: christine.brodigan, Assigned: rik)

Tracking

unspecified
4.11
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: r=98835,98940,98968,98971,98972,99071 b=trunk, URL)

(Reporter)

Description

7 years ago
Background:

Currently, tablet users are hitting the /m site. Now that we have a navigation option for them (Bug 683209), let's serve them the full site, which is a much better content experience on those devices.

This bug is opened per Anthony's recommendation in bug 689987 - Change the download button to give a different download based on the user agent (this might be tricky to do since product-details is an old piece of code)


Assigning to Anthony!
(Reporter)

Updated

7 years ago
Blocks: 699289
(Reporter)

Updated

7 years ago
No longer blocks: 699289
Depends on: 699289
(Reporter)

Updated

7 years ago
Blocks: 699289
No longer depends on: 699289
(Reporter)

Comment 1

7 years ago
Anthony, we would like this in the 4.9 release. If it's not possible, please update in the bug as to why and the steps you will take to get it into X.X release (fill in with the release).
Target Milestone: 4.6 → 4.9
(Reporter)

Comment 2

7 years ago
Anthony, still waiting on an update here. Based on today's website call, please include the following:

*Release milestone update
*steps you are taking to get it into the update
*questions you have

Comment 3

7 years ago
Anthony - Any updates here?
(Assignee)

Comment 4

7 years ago
I'm gonna take a look at this after bug 699285.

One thing though: What should we link to?
(Assignee)

Comment 5

7 years ago
ccing Jaclyn who might know the plans for Firefox tablet.

Jaclyn, please look at comment 4.

Comment 6

7 years ago
Link should go to https://market.android.com/details?id=org.mozilla.firefox - thanks Anthony!

Updated

7 years ago
Target Milestone: 4.9 → 4.10

Updated

7 years ago
Target Milestone: 4.10 → 4.11
(Assignee)

Comment 7

7 years ago
r98834 in product-details, r98835 for mozilla.org.

This takes care of most buttons I could find on en-US.

Now I need to make it work for all locales.
(Reporter)

Comment 8

7 years ago
(In reply to Anthony Ricaud (:rik) from comment #7)
> r98834 in product-details, r98835 for mozilla.org.
> 
> This takes care of most buttons I could find on en-US.
> 
> Now I need to make it work for all locales.

w00t!
(Assignee)

Comment 9

7 years ago
Part of this code was pushed to production today so r98932 and r98933 to fix some Android buttons appearing on production.
(Assignee)

Comment 10

7 years ago
Pushed the fix for unwanted buttons with r98940.
(Assignee)

Comment 11

7 years ago
And now for all locales. r98968

Adding Pascal if he wants to check the code.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Keywords: qawanted
Resolution: --- → FIXED
(Assignee)

Comment 12

7 years ago
Really adding Pascal :)
(Assignee)

Comment 13

7 years ago
r98971 to detect Android before Linux.
(Assignee)

Comment 14

7 years ago
Again, some trials for testing on the tablet. r98972
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 15

7 years ago
Ok that seems ok now.
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
(Assignee)

Comment 16

7 years ago
r99071 to remove the Aurora download for Android.
Whiteboard: r=98835,98940,98968,98971,98972,99071 b=trunk
(Assignee)

Comment 17

7 years ago
Pushed on production with r99153.
verified fixed using stock android browser  http://www.mozilla.org/firefox/new
Status: RESOLVED → VERIFIED
Keywords: qawanted
Component: www.mozilla.org/firefox → www.mozilla.org
Product: Websites → Websites
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.