Closed Bug 699322 Opened 11 years ago Closed 11 years ago

Progress indicator stops when loading CNN.com

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: sriram, Assigned: sriram)

Details

Attachments

(1 file, 1 obsolete file)

The progress indicator stops when trying to load cnn.com
This happens before the page has loaded and any content is shown.
We need to make sure we are only sending messages to Java when the top level window completes it's load. If an iframe fires an event on DOMContentLoaded, we should not send a message to Java.
I found the issue to be because of the order of the events.
We get a Document start before creating a new tab.
This causes the loading to be false. Hence the progress indicator is hidden when the favicon is downloaded - causing the favicon to be updated.

I/Gecko   (22813): Got message: onStateChange
I/GeckoApp(22813): State - 983041
I/GeckoApp(22813): Got a document start
I/Gecko   (22813): Got message: Tab:Added
I/GeckoApp(22813): Created a new tab
I/Tabs    (22813): Added a tab with id: 4, url: http://www.cnn.com/
I/DoorHanger(22813): updateForTab: 4
Attached patch Patch (obsolete) — Splinter Review
I am not sure if this is the right way to fix this issue.
The order of events from Gecko to Java seems to be wrong.
The loading indicator is set to true when a tab is created, to handle this mismatch at Java side.
This is however be fixed on Gecko side too.
Assignee: nobody → sriram
Attachment #571551 - Flags: review?(mark.finkle)
OS: Mac OS X → Android
Hardware: x86 → ARM
Attached patch PatchSplinter Review
This patch ensures that a message is sent to Java, when a tab is created, before starting to load a document.
Attachment #571551 - Attachment is obsolete: true
Attachment #571551 - Flags: review?(mark.finkle)
Attachment #571555 - Flags: review?(mark.finkle)
Attachment #571555 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/projects/birch/rev/b882c5137a07
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
20111103040334
http://hg.mozilla.org/projects/birch/rev/c09a52af4cd8
Samsung Nexus S (Android 2.3.6)
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.