If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Status

Cloud Services
Server: Core
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: tarek, Assigned: tarek)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa+])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
I have externalized ldappool

server-core should use it now
(Assignee)

Comment 1

6 years ago
Created attachment 571969 [details] [diff] [review]
switch to the ldappool lib

now using the external lib. The _ldappool module is just wrapping the exceptions so we keep a persistent behavior.
Assignee: nobody → tarek
Status: NEW → ASSIGNED
Attachment #571969 - Flags: review?(rmiller)
Comment on attachment 571969 [details] [diff] [review]
switch to the ldappool lib

Review of attachment 571969 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/auth/ldapsql.py
@@ +48,4 @@
>  
>  from services.util import BackendError, ssha
>  from services.auth import NodeAttributionError
> +from services._ldappool import ConnectionManager, StateConnector

I see that all of the 'services.ldappool' imports have been changed to 'services._ldappool', but it doesn't look like the name of the module has actually changed.  Is this an oversight, or am I missing something?
(Assignee)

Comment 3

6 years ago
(In reply to Rob Miller [:RaFromBRC :rmiller] from comment #2)
> Comment on attachment 571969 [details] [diff] [review] [diff] [details] [review]
> switch to the ldappool lib
> 
> Review of attachment 571969 [details] [diff] [review] [diff] [details] [review]:
> -----------------------------------------------------------------
> 
> ::: services/auth/ldapsql.py
> @@ +48,4 @@
> >  
> >  from services.util import BackendError, ssha
> >  from services.auth import NodeAttributionError
> > +from services._ldappool import ConnectionManager, StateConnector
> 
> I see that all of the 'services.ldappool' imports have been changed to
> 'services._ldappool', but it doesn't look like the name of the module has
> actually changed.  Is this an oversight, or am I missing something?


the module is now located in an external lib under the "ldappool" module name

services._ldappool is just wrapping it to provide the same errors. It's named _ldappool to avoid the name collision
Whiteboard: [qa+]
Comment on attachment 571969 [details] [diff] [review]
switch to the ldappool lib

Review of attachment 571969 [details] [diff] [review]:
-----------------------------------------------------------------

whoops, lost this one somehow...
Attachment #571969 - Flags: review?(rmiller) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.