699477 - [dev] [stage] Invalid groups shouldn't appear in the groups list

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect, P2)

Description

[Matt Brandt [:mbrandt]]

Attachment: screenshot

Steps to reproduce:
1. goto /user/edit/
2. add a new group, j .2
3. press the return key

Actual:
An error message stating that groups can only contain valid characters is displayed. The group appears to be visually added to the users profile (see screenshot)

Suggested:
The group is not visually present in the users groups if it does not contain valid characters.

Comment 1

[tofumatt [:tofumatt]]

Agreed, this is lazy validation and bad UX.

Comment 2

[[github robot]]

Commit pushed to https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/fcf756a6228f7b6f4e93757540028e96fd9ae197
Disallow bad tag names in JS (fix bug 699477)

Comment 3

[Matt Brandt [:mbrandt]]

Happily we're halfway there with the error behavior. Sadly we've regressed.

1. Nn invalid group is no longer added to the users group list (yay)
2. The error message "Tags can only contain alphanumeric characters, dashes, spaces" is no longer present.

http://screencast.com/t/xz924j7V

Expected:
An error message making note as to why a group could not be added should be presented to the user.

Comment 4

[tofumatt [:tofumatt]]

Of note too -- we shouldn't be calling them tags. I assume this needs to be added to the JS l10n. I'll ask Jen about it.

Comment 5

[[github robot]]

Commit pushed to https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/572b9f7a81857e8f8ce010d747314f96a2a9d11a
Adds js validation messaging to groups.

Also changes "tags" to "groups" in the error messages.

Fixes bug 699477.

Comment 6

[Matt Brandt [:mbrandt]]

Attachment: qa - verified

QA verified on dev - the  error message is displayed, the group is not saved, and the string "tag" has been changed to "group."