[dev] [stage] Invalid groups shouldn't appear in the groups list

VERIFIED FIXED

Status

P2
normal
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: mbrandt, Assigned: pmac)

Tracking

Bug Flags:
in-testsuite ?

Details

(Whiteboard: l10n, URL)

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
Created attachment 571710 [details]
screenshot

Steps to reproduce:
1. goto /user/edit/
2. add a new group, j .2
3. press the return key

Actual:
An error message stating that groups can only contain valid characters is displayed. The group appears to be visually added to the users profile (see screenshot)

Suggested:
The group is not visually present in the users groups if it does not contain valid characters.

Comment 1

7 years ago
Agreed, this is lazy validation and bad UX.
Assignee: nobody → tofumatt
Target Milestone: --- → 1.2

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 3

7 years ago
Happily we're halfway there with the error behavior. Sadly we've regressed.

1. Nn invalid group is no longer added to the users group list (yay)
2. The error message "Tags can only contain alphanumeric characters, dashes, spaces" is no longer present.

http://screencast.com/t/xz924j7V

Expected:
An error message making note as to why a group could not be added should be presented to the user.
Status: RESOLVED → REOPENED
Flags: in-testsuite?
Resolution: FIXED → ---

Comment 4

7 years ago
Of note too -- we shouldn't be calling them tags. I assume this needs to be added to the JS l10n. I'll ask Jen about it.
Priority: -- → P2
Target Milestone: 1.2 → 1.3
Assignee: tofumatt → pmclanahan
Whiteboard: l10n

Comment 5

7 years ago
Commit pushed to https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/572b9f7a81857e8f8ce010d747314f96a2a9d11a
Adds js validation messaging to groups.

Also changes "tags" to "groups" in the error messages.

Fixes bug 699477.
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

7 years ago
Created attachment 595122 [details]
qa - verified

QA verified on dev - the  error message is displayed, the group is not saved, and the string "tag" has been changed to "group."
(Reporter)

Updated

7 years ago
Status: RESOLVED → VERIFIED
(Reporter)

Updated

7 years ago
Component: mozillians.org → Phonebook
Product: Websites → Community Tools
QA Contact: mozillians-org → phonebook
Target Milestone: 1.3 → ---
Version: unspecified → other
You need to log in before you can comment on or make changes to this bug.