Closed Bug 699543 Opened 8 years ago Closed 8 years ago

Show a 'new tab' toast alert when opening a background tab

Categories

(Firefox for Android :: General, defect, P3)

Product:
Firefox for Android
Component:
General
Version:
11 Branch
Platform:
All
Android
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 12
Tracking Flags:
Tracking Status
firefox11 --- verified
firefox12 --- verified
fennec 11+ ---

People

(Reporter: mfinkle, Assigned: ju.vermet)

Details

Attachments

(1 file)

Patch v1
1.94 KB, patch
mbrubeck
: review+
christian
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Give the user a indication something happened. A simple toast alert should suffice.
Assignee: nobody → mbrubeck
OS: Linux → Android
Hardware: x86 → All
Assignee: mbrubeck → ju.vermet
Priority: -- → P3
We also like to do run the tab counter animation in the background tab button.
We'd also like to run the tab counter animation in the background tab button.
Attached patch Patch v1 — — Splinter Review 
Sorry for the delay. Lot of exams and scholar projects...
Attachment #577136 - Flags: review+
Attachment #577136 - Flags: review+ → review?(mark.finkle)
Comment on attachment 577136 [details] [diff] [review]
Patch v1

Stealing this review.  This patch looks good to me.  I'd like to make one small tweak to use the existing string from XUL Fennec ("New tab opened") instead of adding a new one.  I can adjust this before landing the patch.

Requesting approval-mozilla-aurora because I think we want this for the first native Fennec release.
Attachment #577136 - Flags: review?(mark.finkle)
Attachment #577136 - Flags: review+
Attachment #577136 - Flags: approval-mozilla-aurora?
Pushed to inbound, tweaked to use the strings from XUL fennec:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ade76835ad44
Status: NEW → ASSIGNED
status-firefox11: --- → affected
status-firefox12: --- → fixed
Keywords: uiwanted
Target Milestone: --- → Firefox 12
Version: unspecified → Firefox 11
Comment on attachment 577136 [details] [diff] [review]
Patch v1

[triage comment]
Approved for aurora. Mobile-only, wanted for native UI, trivial patch, uses existing l10n string.
Attachment #577136 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: in-litmus?(camelia.urian)
Whiteboard: [QA+]
https://hg.mozilla.org/mozilla-central/rev/ade76835ad44
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Verified with:
Mozilla/5.0 (Android; Linux armv7l; rv:12.0a1) Gecko/20111229 Firefox/12.0a1
Fennec/12.0a1
HTC Desire Z (Android 2.3)

Mozilla/5.0 (Android; Linux armv7l; rv:11.0a2) Gecko/20111229 Firefox/11.0a2
Fennec/11.0a2
HTC Desire Z (Android 2.3)

"New tab opened" toast alert is displayed when opening a background tab.
Status: RESOLVED → VERIFIED
status-firefox11: fixed → verified
status-firefox12: fixed → verified
tracking-fennec: --- → 11+
Updated testcase in litmus: 
https://litmus.mozilla.org/show_test.cgi?id=33853
Flags: in-litmus?(camelia.urian) → in-litmus+
Whiteboard: [QA+]
You need to log in before you can comment on or make changes to this bug.