Closed
Bug 699589
Opened 13 years ago
Closed 13 years ago
Validator / viewer integration borders in file names look odd
Categories
(addons.mozilla.org Graveyard :: Admin/Editor Tools, enhancement, P4)
addons.mozilla.org Graveyard
Admin/Editor Tools
Tracking
(Not tracked)
RESOLVED
FIXED
6.3.6
People
(Reporter: jorgev, Assigned: kmag)
References
()
Details
(Whiteboard: [ReviewTeam])
Attachments
(1 file)
38.36 KB,
image/png
|
Details |
See this page for an example: https://addons.mozilla.org/en-US/firefox/files/browse/135209/ The borders are thick in the corners, and light in the mid points. They look strange, like a badly-cropped image. See attachment of how it looks now.
Comment 1•13 years ago
|
||
Jorge says just getting rid of the thick corners is enough to close this bug. If people want to do more UX office hours are on Friday and could probably give some good suggestions.
Assignee | ||
Comment 2•13 years ago
|
||
That's bug 382721. We may as well just make the borders solid. Related: • We need a colors key. Hovering over a highlighted line numbers should be enough to discover the meanings, but a lot of editors have been confused. • Notices are sometimes yellow, sometimes blue, depending on the location. They should just be blue everywhere.
Comment 3•13 years ago
|
||
https://addons.mozilla.org/en-US/firefox/files/browse/135209/ 404'd for me Can you send another example page?
Comment 4•13 years ago
|
||
I think Jason might be doing this. I gave him access and he logged in and poked around.
Reporter | ||
Comment 5•13 years ago
|
||
Try this: https://addons.mozilla.org/en-US/firefox/files/browse/136810/
Comment 6•13 years ago
|
||
Jason: did you have feedback on this?
Comment 7•13 years ago
|
||
I originally hoped to be able to give you guys some CSS to use, but I'm having a hard time doing that. I'm going to just cut my losses there and just give you my recommendations instead. Here they are: http://cl.ly/3l0E311D3Y2c1W3l2E0L - Make colors of errors/warnings/notices icons match the colors of the highlight in the file browser and the messages at the top of the page. - errors (should rarely be seen): red, with red exclamation point icon - warnings: yellow, with yellow exclamation point icon - notices: blue, with blue info icon - Files with errors/warnings/notices should be bolded to draw attention to them. - If a file/directory would have multiple types of icons to display, only display the "most important" one - errors > warnings > notices. Note: in the mockup I've used icons from https://github.com/jbalogh/zamboni/blob/master/media/img/zamboni/notifications.png , which seem to be what is used in the warning and error messages in the validator. Consistency ftw :D Bonus: - I think a more attractive way to show which item is selected would be to reverse out the link color as the background: http://cl.ly/2H3d3j1j2B3p0X0h2k41 Hope this helps!
Assignee | ||
Comment 8•13 years ago
|
||
I can do the CSS for this, but I still have a related patch for 661688 that needs to be updated, so it's up to you which you want first.
Comment 9•13 years ago
|
||
Thanks Jason and Kris. Kris: whichever you like.
Assignee: nobody → maglione.k
Assignee | ||
Comment 10•13 years ago
|
||
https://github.com/mozilla/zamboni/pull/270 Screenshot: http://666kb.com/i/bzl0ammgbclfztsc7.png (the info indicator has since been moved 4px rightward). Incidentally, I'm now getting "Validation failed: ValueError: signal only works in main thread" when I try to get non-cached validator results. I had to kick off the task by hand from a console. Am I missing something in my local install?
Comment 11•13 years ago
|
||
I haven't heard of that
Comment 12•13 years ago
|
||
https://github.com/mozilla/zamboni/commit/9395dae
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: Q4 2011 → 6.3.6
Reporter | ||
Comment 13•12 years ago
|
||
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•