699658 - Enable filtering on elements in edit-env-profile page

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: MozTrap, defect)

Description

[Carl Meyer (:carljm)]

Platform supports this now, we should too

Comment 1

[Cameron Dawson [:camd]]

A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/20574997

Comment 2

[Cameron Dawson [:camd]]

Carl Meyer changed story state to started in Pivotal Tracker

Comment 3

[Cameron Dawson [:camd]]

Carl Meyer added a comment in Pivotal Tracker:   
   
I realized we hadn't re-added filtering by element to the env-profile-edit page since it was added in the platform, and it really should be there. Didn't take me long to add it, but it needs a bit of style attention.

Also, jonny, you were using the autocomplete_suggestion and autocomplete_input ICH templates for add-environment, and they are also used for filtering. I had to remove them from add-environment so they weren't duplicated on the page. I'm not sure how you prefer to handle this case, it seemed like you might want some marker still in the template for add-environment to indicate the ICH templates that it depends on that are included elsewhere. Anyway, you can see how I commented them out in the commit, and tweak as you prefer: https://github.com/mozilla/caseconductor-ui/commit/ca91ae0179ca2097a7e0230598ebee2eb23c6f43

Comment 4

[Cameron Dawson [:camd]]

Jonny Gerig Meyer added a comment in Pivotal Tracker:   
   
Carl: What you did makes perfect sense to me. I removed the unused {% load icanhaz %}, but the comments look good.

Comment 5

[Cameron Dawson [:camd]]

Eric Meyer changed story state to finished in Pivotal Tracker

Comment 6

[Cameron Dawson [:camd]]

Carl Meyer changed story state to delivered in Pivotal Tracker

Comment 7

[Cameron Dawson [:camd]]

Cameron Dawson changed story state to accepted in Pivotal Tracker