Do not prevent sending levelchange event if the change is less than 0.01

RESOLVED FIXED in mozilla11

Status

()

Core
Widget: Android
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
The specs required that but do not anymore. In addition, the backend should be smart enough to not send us too many events. If not, we will be able to tweak that later. In the meantime, let's have a simple implementation.
(Assignee)

Comment 1

6 years ago
Created attachment 571926 [details] [diff] [review]
Patch v1

The Android backend is still going to check if there is a change which the upower backend does not because the DOM code already checks that before sending the events. The idea is to prevent going through JNI then from the parent process to the child process to finally not send the event.
Attachment #571926 - Flags: review?(jones.chris.g)
Attachment #571926 - Flags: review?(jones.chris.g) → review+
(Assignee)

Updated

6 years ago
Flags: in-testsuite-
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 2

6 years ago
Comment on attachment 571926 [details] [diff] [review]
Patch v1

This has just landed in mozilla-inbound. Requesting aurora approval for API completeness in Firefox 10. It would be better to ship Firefox 10 with the entire API if we say it is present. The risk is very low given that there is no use of the API for the moment.
Attachment #571926 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/14e180318688
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11

Comment 4

6 years ago
Comment on attachment 571926 [details] [diff] [review]
Patch v1

It looks like this feature wasn't ready for 10. Please re-nominate if you have a good justification for trying to get this into 10 rather than just waiting for 11.
Attachment #571926 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
You need to log in before you can comment on or make changes to this bug.