The default bug view has changed. See this FAQ.

Redundant call to Seek() in nsStorageStream::GetOutputStream()

RESOLVED FIXED in mozilla10

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: bjarne, Assigned: bjarne)

Tracking

Trunk
mozilla10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
There is an unconditional second call to Seek() after a possible call to ReallocLastSegment(). Looks like the second seek is only needed if realloc was done?
(Assignee)

Comment 1

5 years ago
Created attachment 572403 [details] [diff] [review]
Proposed fix

Looks like base pointer changed only on positive return from ReallocLastSegment(). Maybe we should add this to the doc for ReallocLastSegment() as well...?
Assignee: nobody → bjarne
Attachment #572403 - Flags: review?(benjamin)
Attachment #572403 - Flags: review?(benjamin) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Please could you tweak your hgrc to automatically add author info (guide here: http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed) + add a commit message when attaching patches, since it makes pushing half a dozen checkin-neededs a lot easier. Thanks :-)
Status: NEW → ASSIGNED
(Assignee)

Comment 3

5 years ago
Created attachment 572589 [details] [diff] [review]
Proposed fix w/ proper metainfo

Sorry - added here...
Attachment #572403 - Attachment is obsolete: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/234289676c7e
Keywords: checkin-needed
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/234289676c7e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.