Closed
Bug 699780
Opened 13 years ago
Closed 13 years ago
Redundant call to Seek() in nsStorageStream::GetOutputStream()
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: bjarne, Assigned: bjarne)
Details
Attachments
(1 file, 1 obsolete file)
|
1.24 KB,
patch
|
Details | Diff | Splinter Review |
There is an unconditional second call to Seek() after a possible call to ReallocLastSegment(). Looks like the second seek is only needed if realloc was done?
|
Assignee | |
Comment 1•13 years ago
|
||
Looks like base pointer changed only on positive return from ReallocLastSegment(). Maybe we should add this to the doc for ReallocLastSegment() as well...?
Assignee: nobody → bjarne
Attachment #572403 -
Flags: review?(benjamin)
|
||
Updated•13 years ago
|
Attachment #572403 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 2•13 years ago
|
||
Please could you tweak your hgrc to automatically add author info (guide here: http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed) + add a commit message when attaching patches, since it makes pushing half a dozen checkin-neededs a lot easier. Thanks :-)
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•13 years ago
|
||
Sorry - added here...
Attachment #572403 -
Attachment is obsolete: true
|
|
||
Comment 4•13 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → mozilla10
|
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•