There is an unconditional second call to Seek() after a possible call to ReallocLastSegment(). Looks like the second seek is only needed if realloc was done?
Created attachment 572403 [details] [diff] [review] Proposed fix Looks like base pointer changed only on positive return from ReallocLastSegment(). Maybe we should add this to the doc for ReallocLastSegment() as well...?
Assignee: nobody → bjarne
Attachment #572403 - Flags: review?(benjamin)
Please could you tweak your hgrc to automatically add author info (guide here: http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed) + add a commit message when attaching patches, since it makes pushing half a dozen checkin-neededs a lot easier. Thanks :-)
Status: NEW → ASSIGNED
Created attachment 572589 [details] [diff] [review] Proposed fix w/ proper metainfo Sorry - added here...
Attachment #572403 - Attachment is obsolete: true
Target Milestone: --- → mozilla10
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.