Closed Bug 699780 Opened 9 years ago Closed 9 years ago

Redundant call to Seek() in nsStorageStream::GetOutputStream()

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: bjarne, Assigned: bjarne)

Details

Attachments

(1 file, 1 obsolete file)

There is an unconditional second call to Seek() after a possible call to ReallocLastSegment(). Looks like the second seek is only needed if realloc was done?
Attached patch Proposed fix (obsolete) — Splinter Review
Looks like base pointer changed only on positive return from ReallocLastSegment(). Maybe we should add this to the doc for ReallocLastSegment() as well...?
Assignee: nobody → bjarne
Attachment #572403 - Flags: review?(benjamin)
Attachment #572403 - Flags: review?(benjamin) → review+
Keywords: checkin-needed
Please could you tweak your hgrc to automatically add author info (guide here: http://blog.bonardo.net/2010/06/22/so-youre-about-to-use-checkin-needed) + add a commit message when attaching patches, since it makes pushing half a dozen checkin-neededs a lot easier. Thanks :-)
Status: NEW → ASSIGNED
Sorry - added here...
Attachment #572403 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/234289676c7e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.