Don't AddRef/Release every uncollectable document before cycle collection

RESOLVED FIXED in mozilla10

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: peterv, Assigned: peterv)

Tracking

Trunk
mozilla10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 571971 [details] [diff] [review]
v1

The Release adds the document to the cycle collector as a suspect, even though we know it's not collectable (that's the whole point of the code in nsCCUncollectableMarker).
Attachment #571971 - Flags: review?(jst)

Updated

6 years ago
Attachment #571971 - Flags: review?(jst) → review+
Is this just going to avoid adding the document itself, due to the nsCCUncollectableMarker optimization, or will it pull in some successors of the document too?  One thing I want to look into is what exactly the large DOM-y globs that show up in the cycle collector graph actually are.  One theory I've had is that we aren't pruning out all visible documents that we should.
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1aab8b1485dd
Target Milestone: --- → mozilla10
(Assignee)

Comment 3

6 years ago
(In reply to Andrew McCreight [:mccr8] from comment #1)
> Is this just going to avoid adding the document itself, due to the
> nsCCUncollectableMarker optimization

I think so, yes.
https://hg.mozilla.org/mozilla-central/rev/1aab8b1485dd
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.