Closed Bug 699799 Opened 8 years ago Closed 8 years ago

Don't AddRef/Release every uncollectable document before cycle collection

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: peterv, Assigned: peterv)

Details

Attachments

(1 file)

Attached patch v1Splinter Review
The Release adds the document to the cycle collector as a suspect, even though we know it's not collectable (that's the whole point of the code in nsCCUncollectableMarker).
Attachment #571971 - Flags: review?(jst)
Attachment #571971 - Flags: review?(jst) → review+
Is this just going to avoid adding the document itself, due to the nsCCUncollectableMarker optimization, or will it pull in some successors of the document too?  One thing I want to look into is what exactly the large DOM-y globs that show up in the cycle collector graph actually are.  One theory I've had is that we aren't pruning out all visible documents that we should.
(In reply to Andrew McCreight [:mccr8] from comment #1)
> Is this just going to avoid adding the document itself, due to the
> nsCCUncollectableMarker optimization

I think so, yes.
https://hg.mozilla.org/mozilla-central/rev/1aab8b1485dd
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.