Closed Bug 699825 Opened 13 years ago Closed 13 years ago

Ensure valid 3pane layout pref value, UI fail if not.

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
normal

Tracking

(thunderbird9 fixed)

RESOLVED FIXED
Thunderbird 10.0
Tracking Status
thunderbird9 --- fixed

People

(Reporter: alta88, Assigned: alta88)

Details

Attachments

(1 file)

Attached patch fix.Splinter Review
need to ensure the value is valid, since manual or extension change to invalid value results in UI failure.
Attachment #572002 - Flags: review?(mbanner)
Attachment #572002 - Flags: approval-comm-aurora?
I'm not sure I agree with this. Have we had a case of an extension incorrectly setting this value?

Generally with manual setting, users do so at their own risk, so if they set the value wrong, that's up to them.

What I'm concerned about is if we start taking these checks for all our various prefs, we're going to start having a lot of redundant checking all over the code base.
yes, MoreLayouts by definition sets this value to other possibilities, and when uninstalled with a no longer available layout value, causes havoc. (it's not like i went looking for things to do :)

given that, the right place for ensuring validity is here, and not in an extension uninstall procedure.

i don't see how you extrapolate this to 'all over the code base', nor do i see that this check is 'redundant', nor why 'checking' is of 'concern' when non checking causes breakage.
Attachment #572002 - Flags: review?(mbanner)
Attachment #572002 - Flags: review+
Attachment #572002 - Flags: approval-comm-aurora?
Attachment #572002 - Flags: approval-comm-aurora+
Checked into trunk:

http://hg.mozilla.org/comm-central/rev/e2f56742693c
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
You need to log in before you can comment on or make changes to this bug.