699855 - Build OSR unconditionally

Status: RESOLVED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Edwin Smith]

Currently, VMCFG_OSR controls whether OSR functionality is built, as well as enabling it by setting the default OSR policy.

Instead, lets build it always, and let VMCFG_OSR only decide the default policy of disabled (compatible with the hybrid policy we ship now) or enabled (interpret, then JIT after a preset threshold).

Thus, all shell and player builds will have OSR in a buildable/testable state, Air/Android will continue to get its OSR=17 policy as now, and everyone else gets the OSR=0 policy as they do now.

Comment 1

[Edwin Smith]

Player is abusing feature-switch names by switching on 

  #if AVMFEATURE_OSR

instead of

  #ifdef VMCFG_OSR

Fixing this bug will require a minor change to player to unconditionally parse AS3OSR as well, but we should also fix the abuse of AVMFEATURE_OSR.  See also: bug 696067, which aims to tighten up the way config switches are used.

Comment 2

[Edwin Smith]

Attachment: Only use VMCFG_OSR to change the default OSR policy

with VMCFG_OSR, we use OSR=17.  Without, we use OSR=0 (legacy policy).  OSR mechanism is compiled in when JIT is enabled.

Comment 3

[Edwin Smith]

tamarin-redux
changeset:   6779:f568348f026e
tag:         tip
user:        Edwin Smith <[e-mail]>
date:        Fri Dec 09 14:03:26 2011 -0500
summary:     Bug 699855 - Build OSR unconditionally (r=wmaddox+)