Closed Bug 699876 Opened 8 years ago Closed 8 years ago

Import the initial b2g/ directory

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: vingtetun, Assigned: philikon)

References

Details

Attachments

(1 file, 2 obsolete files)

This bug will track our progress to upstream the b2g/ directory from http://github.com/cgjones/mozilla-central to m-c.

The current directory structure is based on the Mobile's one but stripped down to the minimal.
There is a simple shell.xul file that embed a <xul:browser/> pointing to the homescreen.
The hard-coded home screen locations may be a hard sell.  I think making those pref(s) might be part of the entry fee.  Shouldn't be too bad, yeah?
Another thing I think we should ensure before upstreaming is that all the "fennec" branding is switched over to "b2g".
(In reply to Chris Jones [:cjones] [:warhammer] from comment #2)
> Another thing I think we should ensure before upstreaming is that all the
> "fennec" branding is switched over to "b2g".

This should have been done in my last commit but looking twice can't be bad.
Attached patch B2G dir (obsolete) — Splinter Review
This is the b2g/ directory with the basic app to launch the homescreen and without the mobile/ leftover.
The homescreen can be configured via the preference browser.homescreenURL.
Assignee: nobody → 21
Attachment #575825 - Attachment is obsolete: true
Attachment #578334 - Flags: review?(jones.chris.g)
Comment on attachment 578334 [details] [diff] [review]
B2G dir (without application.ini)

OK, just to warn you, you're going to hate this comment ...

The original setup of b2g was as a copy of mobile/ since the vast majority of the code is the same.  Using a copy instead of "new file" allows us to follow history.  That's quite useful.  In this import though, all the files are new, so we would lose history.

I would really like to keep the history if possible.  Before the reorganization of mobile/, I think you could pretty easily have "fixed" this patch to do copies.  After, I'm not sure.  I'd like to see this patch fixed to use copies, but otherwise convince me that it's too hard to be worthwhile with the new code
Attachment #578334 - Flags: review?(jones.chris.g)
Assignee: 21 → philipp
Attachment #578334 - Attachment is obsolete: true
Attachment #579261 - Flags: review?(jones.chris.g)
Just keeping the bug assigned to me since if something went wrong I will probably keep fixing b2g/ myself since what you have just done is rebasing the patch to keep the mobile history - and btw thanks a lot for that!
Assignee: philipp → 21
Comment on attachment 579261 [details] [diff] [review]
b2g/ dir as a copy of mobile/xul/

touch.js needs a license header.

r=me with that.
Attachment #579261 - Flags: review?(jones.chris.g) → review+
(In reply to Vivien Nicolas (:vingtetun) from comment #8)
> Just keeping the bug assigned to me since if something went wrong I will
> probably keep fixing b2g/ myself since what you have just done is rebasing
> the patch to keep the mobile history - and btw thanks a lot for that!

Let's just land this and deal with any problems in the follow up.

(In reply to Chris Jones [:cjones] [:warhammer] from comment #9)
> touch.js needs a license header.

Thanks for the quick review! Will do.
Assignee: 21 → philipp
https://hg.mozilla.org/mozilla-central/rev/e2ba243f96a5
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Blocks: 709468
You need to log in before you can comment on or make changes to this bug.