699880 - PerfConfigurator should err out if no tests are specified

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Jeff Hammel]

Currently if you don't specify --activeTests, all of the tests
specified in sample.config get set to be run.  This includes obselete
tests like ts_cold.  Instead, we should require that --activeTests be called.

Comment 1

[Burak Yiğit Kaya [:BYK]]

Attachment: Simple check to verifyCommandLine for activeTests emptiness.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 572930 [details] [diff] [review]
Simple check to verifyCommandLine for activeTests emptiness.

Review of attachment 572930 [details] [diff] [review]:
-----------------------------------------------------------------

thanks, this looks great.

Comment 3

[William Lachance (:wlach)]

Comment on attachment 572930 [details] [diff] [review]
Simple check to verifyCommandLine for activeTests emptiness.

Review of attachment 572930 [details] [diff] [review]:
-----------------------------------------------------------------

Quick request, could we remove the following code as well? It's obviously no longer valid.

(PerfConfigurator.py around line 152):

#only do this if the user has provided a list of tests to turn on/off
# otherwise, all tests are considered to be active
if self.activeTests:

Comment 4

[Burak Yiğit Kaya [:BYK]]

Attachment: Added a simple check to assert non-empty activeTests in verifyCommandLine and removed empty-checks for it in other places.

Comment 5

[William Lachance (:wlach)]

Comment on attachment 572981 [details] [diff] [review]
Added a simple check to assert non-empty activeTests in verifyCommandLine and removed empty-checks for it in other places.

Looks great, thanks.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/build/talos/rev/62447d5642c4