699937 - content overpan gets stuck over panning

Status: VERIFIED FIXED

Description

[Brad Lassey [:blassey] (use needinfo?)]

Created attachment 572091 [details]
screen shot

with pcwalton's patches applied I tried panning and wound up with the content stuck at the bottom of the page

Comment 2

[Kartikaya Gupta (email:[e-mail])]

I've seen this happen as well, it happens if you fling the page into overscroll and then do a tap. The tap for some reason cancels the page snapping back, and so it gets stuck in overscroll. Happens on current birch tip as well.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Created attachment 575874 [details] [diff] [review]
(1/2) Some cleanup

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Created attachment 575875 [details] [diff] [review]
(2/2) Fix for stuck-in-overpanning

Comment 5

[Chris Lord [:cwiiis]]

Comment on attachment 575874 [details] [diff] [review]
(1/2) Some cleanup

Review of attachment 575874 [details] [diff] [review]:
-----------------------------------------------------------------

Fine of course, this variable is unused.

Comment 6

[Chris Lord [:cwiiis]]

Comment on attachment 575875 [details] [diff] [review]
(2/2) Fix for stuck-in-overpanning

Review of attachment 575875 [details] [diff] [review]:
-----------------------------------------------------------------

I did the same thing in my patches and I think this makes the same mistake - if you call fling like this, you need to make sure to cancel the fling timer on touch-down, otherwise you end up offsetting the velocity twice as the fling handler is still running when you start panning.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Created attachment 575905 [details] [diff] [review]
(2/2) Fix for stuck-in-overpanning (v2)

Good catch, thanks. I've moved the code to cancel the timer up to the beginning of onTouchStart.

Comment 8

[Chris Lord [:cwiiis]]

Comment on attachment 575905 [details] [diff] [review]
(2/2) Fix for stuck-in-overpanning (v2)

Review of attachment 575905 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - I assume it's tested to work, so r+ from me!

Comment 9

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/projects/birch/rev/be195eac506c
https://hg.mozilla.org/projects/birch/rev/afc56afc464f

Comment 10

[Catalin Suciu [:csuciu]]

I cannot reproduce this issue on the latest fennec native build.
Mozilla/5.0 (Android;Linux armv7l;rv:11.0a1)Gecko/20111123 Firefox/11.0a1 Fennec/11.0a1
Samsung GalaxyS, Android 2.2