Closed Bug 699937 Opened 11 years ago Closed 11 years ago

content overpan gets stuck over panning


(Firefox for Android Graveyard :: General, defect, P1)



(firefox11 fixed, fennec11+)

Tracking Status
firefox11 --- fixed
fennec 11+ ---


(Reporter: blassey, Assigned: kats)




(3 files, 1 obsolete file)

Attached image screen shot
with pcwalton's patches applied I tried panning and wound up with the content stuck at the bottom of the page
Duplicate of this bug: 700008
Priority: -- → P1
Assignee: nobody → kgupta
I've seen this happen as well, it happens if you fling the page into overscroll and then do a tap. The tap for some reason cancels the page snapping back, and so it gets stuck in overscroll. Happens on current birch tip as well.
Attachment #575874 - Flags: review?(
Attachment #575875 - Flags: review?(
Comment on attachment 575874 [details] [diff] [review]
(1/2) Some cleanup

Review of attachment 575874 [details] [diff] [review]:

Fine of course, this variable is unused.
Attachment #575874 - Flags: review?( → review+
Comment on attachment 575875 [details] [diff] [review]
(2/2) Fix for stuck-in-overpanning

Review of attachment 575875 [details] [diff] [review]:

I did the same thing in my patches and I think this makes the same mistake - if you call fling like this, you need to make sure to cancel the fling timer on touch-down, otherwise you end up offsetting the velocity twice as the fling handler is still running when you start panning.
Attachment #575875 - Flags: review?( → review-
Good catch, thanks. I've moved the code to cancel the timer up to the beginning of onTouchStart.
Attachment #575875 - Attachment is obsolete: true
Attachment #575905 - Flags: review?(
Comment on attachment 575905 [details] [diff] [review]
(2/2) Fix for stuck-in-overpanning (v2)

Review of attachment 575905 [details] [diff] [review]:

Looks good - I assume it's tested to work, so r+ from me!
Attachment #575905 - Flags: review?( → review+
I cannot reproduce this issue on the latest fennec native build.
Mozilla/5.0 (Android;Linux armv7l;rv:11.0a1)Gecko/20111123 Firefox/11.0a1 Fennec/11.0a1
Samsung GalaxyS, Android 2.2
tracking-fennec: --- → 11+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.