700024 - Password reset mail has unlocalizable subject

Status: VERIFIED INVALID

(Participation Infrastructure :: Phonebook, defect)

Description

[Pavel Cvrcek [:JasnaPaka]]

1) Visit https://mozillians-dev.allizom.org/cs/password_reset.
2) Fill mail for your account and send mail.

You recieve mail which is in czech. But subject and title are in english. These strings should be in czech too.

Comment 1

[tofumatt [:tofumatt]]

The dev server has all "supported" locales enabled, but some locales do not have full translations. These strings are localizable, but haven't been translated to Czech yet.

(See: https://github.com/mozilla/mozillians/blob/master/apps/users/views.py#L30)

Comment 2

[Pavel Cvrcek [:JasnaPaka]]

(In reply to Matthew Riley MacPherson [:tofumatt] from comment #1)
> The dev server has all "supported" locales enabled, but some locales do not
> have full translations. These strings are localizable, but haven't been
> translated to Czech yet.

* Czech translation is fully translated (see https://localize.mozilla.org/projects/mozillians/).
* I don't talk about confirmation mail, I talk about password reset mail.

English string in mail is untranslatable:
* https://github.com/mozilla/mozillians/blob/master/apps/users/templates/registration/password_reset_email.html#L1

English subjekt is different problem. I see it translatable in the source code:
* https://github.com/mozilla/mozillians/blob/master/apps/users/templates/registration/password_reset_subject.txt (hope this is the right file)

But I don't see such string in my .po file.

Comment 3

[[github robot]]

Commit pushed to https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/3f51318894093a2f10eedeb8b69d6b34ee2c8ab9
Localize "password reset" (fix bug 700024)

Comment 4

[Matt Brandt [:mbrandt]]

With BrowserID now in place on dev is this an issue or has the code been removed?

Comment 5

[tofumatt [:tofumatt]]

This was fixed, but with BrowserID it doesn't matter anymore. I'll mark it as invalid now.

Comment 6

[Matt Brandt [:mbrandt]]

QA verified invalid per comment 5 and my super-qa-intellegences.