700038 - float4Array.join() failure in Float4/flt4_4_6_5_1

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Brent Baker]

Investigation by Virgil:

Float4/flt4_4_6_5_1:  The result reads “ float4Array.join() = |1,1,1,1|2,2,2,2|3,3,3,3 FAILED! expected: 0,0,0,0|1,1,1,1|2,2,2,2|3,3,3,3 “

Obvious failure, right? (given that float4Array = [float4(0),float4(1),float4(2), float4(3)]). Well… not so fast. The Array.prototype.join() function says:
[….]
                var x = o[i]
                if (x != null)
                    out += x
 
[….]
Now, first element is float4(0). If we look at the abstract equality operator, we notice that “null” is compared to a “float4” by converting it to float4, resulting float4(0) – i.e. float4(0)==null.
The question is what is really wrong here:
1.       The float/float4 spec (equality operator)? That would be my first pick, given that comparing a float or Number to null yields “false” (step 18)
2.       The Array.join spec/implementation?
3.       The test media?

Comment 1

[Lars T Hansen]

Bug in the float4 spec.

Comment 2

[Brent Baker]

changeset:   6793:fbb7b598c073
user:        Virgil Palanciuc <[e-mail]>
date:        Mon Nov 07 19:06:33 2011 +0200
files:       core/AvmCore.cpp
description:
fixed issue 700038

Comment 3

[Tamarin Bot]

changeset: 6883:63bef4ee7d8a
user:      Brent Baker <[e-mail]>
summary:   Bug 700038: remove expected fail now that it is fixed via 6793:fbb7b598c073

http://hg.mozilla.org/tamarin-redux/rev/63bef4ee7d8a