Closed Bug 700043 Opened 13 years ago Closed 13 years ago

JIT not handling stricteq between float and Number

Categories

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)

Product:
Tamarin Graveyard
Component:
Baseline JIT (CodegenLIR)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: brbaker, Unassigned)

References

Details

The JIT is still allowing a strict equality between Number and float values. This does not match the ABC Extensions spec for "4.4.2 Abstract strict equality" which stats that if type1 does not match type2 then return false.

The interpreter and asc get this correct

var onef:float = 1f;
var onen:Number = 1;

print(onef === onen);

-Ojit: produces a true when it should be false


testmedia:
as3/Types/Float/flt_6_8_3.as
as3/Types/Float/flt_6_8_4.as
as3/Types/Float/flt_6_8_5.as
Flags: in-testsuite+
Flags: flashplayer-triage+
Flags: flashplayer-qrb+
Flags: flashplayer-bug-
There are also 2 failures in as3/Types/Float/floatOperations due to this bug
Fixed in changeset 6805:36c13def9546
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Verified fixed with osx 32bit release-debugger and debug-debugger, update failconfig.txt in changeset 6806:689ace3addd8
Status: RESOLVED → VERIFIED
changeset: 6865:d6be86ee0e47
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 700043: changes to !== and === to no longer allow Float(v) === Number(v), there are still some issues with the JIT not following the spec at the moment and those are tracked and expected failures.

http://hg.mozilla.org/tamarin-redux/rev/d6be86ee0e47
changeset: 6879:ead4a42c6429
user:      Virgil Palanciuc <virgilp@adobe.com>
summary:   fix issues 700043 , 700258

http://hg.mozilla.org/tamarin-redux/rev/ead4a42c6429
You need to log in before you can comment on or make changes to this bug.