Last Comment Bug 700261 - Add .chargingTime/.dischargingTime support to hal code
: Add .chargingTime/.dischargingTime support to hal code
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla11
Assigned To: Mounir Lamouri (:mounir)
:
Mentors:
Depends on: 699743 699744
Blocks: 700262 700263
  Show dependency treegraph
 
Reported: 2011-11-07 04:10 PST by Mounir Lamouri (:mounir)
Modified: 2011-11-15 14:47 PST (History)
4 users (show)
mounir: in‑testsuite?
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (5.21 KB, patch)
2011-11-07 04:10 PST, Mounir Lamouri (:mounir)
cjones.bugs: review+
asa: approval‑mozilla‑aurora-
Details | Diff | Splinter Review

Description Mounir Lamouri (:mounir) 2011-11-07 04:10:02 PST
Created attachment 572428 [details] [diff] [review]
Patch v1

This doesn't do the backends implementations.
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-11-07 20:25:52 PST
Comment on attachment 572428 [details] [diff] [review]
Patch v1

dom::battery::kUnknownRemainingTime needs to be defined somewhere, right?
Comment 2 Mounir Lamouri (:mounir) 2011-11-08 00:58:30 PST
(In reply to Chris Jones [:cjones] [:warhammer] from comment #1)
> Comment on attachment 572428 [details] [diff] [review] [diff] [details] [review]
> Patch v1
> 
> dom::battery::kUnknownRemainingTime needs to be defined somewhere, right?

In the DOM patch.
Comment 3 Mounir Lamouri (:mounir) 2011-11-09 06:23:03 PST
Comment on attachment 572428 [details] [diff] [review]
Patch v1

This has just landed in mozilla-inbound. Requesting aurora approval for API completeness in Firefox 10. It would be better to ship Firefox 10 with the entire API if we say it is present. The risk is very low given that there is no use of the API for the moment.
Comment 4 Marco Bonardo [::mak] 2011-11-10 03:10:34 PST
https://hg.mozilla.org/mozilla-central/rev/6918831fdd2f
Comment 5 Asa Dotzler [:asa] 2011-11-15 14:47:24 PST
Comment on attachment 572428 [details] [diff] [review]
Patch v1

It looks like this feature wasn't ready for 10. Please re-nominate if you have a good justification for trying to get this into 10 rather than just waiting for 11.

Note You need to log in before you can comment on or make changes to this bug.