nsWindow::BringToFront doesn't handle first opened window properly

RESOLVED FIXED in mozilla11

Status

()

Core
Widget: Android
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Neil Deakin (not available until Aug 9), Assigned: Neil Deakin (not available until Aug 9))

Tracking

(Blocks: 1 bug)

Trunk
mozilla11
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 572443 [details] [diff] [review]
confirm the active window with the focus manager

There is a check that returns early if the window to raise is the current top window, but that check simply looks to see if the window is first in the window list. The means that the very first window will be first in the list but can't be brought to the front, meaning that the focus manager never gets informed of its existence.

Conveniently, the first window currently is always the hidden window, no noticeable issue occurs. However, when the hidden window is removed, this causes a bug when the first window never focuses, preventing, for example, the keyboard from appearing.
Attachment #572443 - Flags: review?(blassey.bugs)
Just a note, that this fix will help us remove the need for a HiddenWindow on Android, which should improve startup speed.
Attachment #572443 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/31328657b6d6
Assignee: nobody → enndeakin
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.