Last Comment Bug 700277 - nsWindow::BringToFront doesn't handle first opened window properly
: nsWindow::BringToFront doesn't handle first opened window properly
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget: Android (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla11
Assigned To: Neil Deakin
:
Mentors:
Depends on:
Blocks: 71895
  Show dependency treegraph
 
Reported: 2011-11-07 05:45 PST by Neil Deakin
Modified: 2011-11-09 05:27 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
confirm the active window with the focus manager (1.42 KB, patch)
2011-11-07 05:45 PST, Neil Deakin
blassey.bugs: review+
Details | Diff | Splinter Review

Description Neil Deakin 2011-11-07 05:45:50 PST
Created attachment 572443 [details] [diff] [review]
confirm the active window with the focus manager

There is a check that returns early if the window to raise is the current top window, but that check simply looks to see if the window is first in the window list. The means that the very first window will be first in the list but can't be brought to the front, meaning that the focus manager never gets informed of its existence.

Conveniently, the first window currently is always the hidden window, no noticeable issue occurs. However, when the hidden window is removed, this causes a bug when the first window never focuses, preventing, for example, the keyboard from appearing.
Comment 1 Mark Finkle (:mfinkle) (use needinfo?) 2011-11-07 05:49:19 PST
Just a note, that this fix will help us remove the need for a HiddenWindow on Android, which should improve startup speed.
Comment 2 Marco Bonardo [::mak] 2011-11-09 05:27:20 PST
https://hg.mozilla.org/mozilla-central/rev/31328657b6d6

Note You need to log in before you can comment on or make changes to this bug.