landing of nsIUBidiUtils.h and implementation

RESOLVED FIXED in mozilla0.9.1

Status

()

Core
Internationalization
RESOLVED FIXED
17 years ago
16 years ago

People

(Reporter: Frank Tang, Assigned: Frank Tang)

Tracking

Trunk
mozilla0.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(7 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

17 years ago
Created attachment 26078 [details]
nsIUBidiUtils.h without Arabic shapping functions
(Assignee)

Comment 2

17 years ago
Created attachment 26079 [details]
bidicattable.h
(Assignee)

Comment 3

17 years ago
Created attachment 26080 [details]
symmtable.h
(Assignee)

Comment 4

17 years ago
Created attachment 26081 [details]
nsBidiUtilsImp.h
(Assignee)

Comment 5

17 years ago
Created attachment 26082 [details]
nsBidiUtilsImp.cpp
(Assignee)

Comment 6

17 years ago
submit by smontagur@il.ibm.com
r=ftang
sr=erik
Status: NEW → ASSIGNED
(Assignee)

Comment 7

17 years ago
check in these 5 files. Need to add into the build after nsIBidi.h land.

Comment 8

17 years ago
Simon, if you like, I think it's possible to change all of your softel.co.il
entries in bugzilla to your IBM address. (You don't have to do this; I just
thought you might want to.)
Created attachment 26253 [details]
Adding gensymmtable.pl (generates the version of symmtable.h in attachment 26080 [details] above)

Comment 10

17 years ago
Changed QA contact to ftang@netscape.com.
QA Contact: teruko → ftang
(Assignee)

Comment 11

17 years ago
r=ftang

Comment 12

17 years ago
previous r=ftang was for gensymmtable.pl

sr=erik for the same file

Comment 13

17 years ago
gensymmtable.pl changes checked in. Makefiles not checked in yet.
(Assignee)

Comment 14

17 years ago
Check in most of the code. But we still need to review the Arabic shapping code. 
That part is still not fully work. I check in the code in a #ifdef which default 
to false. 
(Assignee)

Comment 15

17 years ago
Mark the remainning part as moz0.9
Target Milestone: --- → mozilla0.9
The code within #ifdef FULL_ARABIC_SHAPING doesn't build as is.

NS_ConvertToString is no longer defined (see bug 73339), and should be replaced
by NS_LITERAL_STRING.

aSrcUnichars should be replaced by srcUnichars throughout for coding convention
compliance
Created attachment 29402 [details] [diff] [review]
diffs on nsBidiUtilsImp.cpp
(Assignee)

Comment 18

17 years ago
simon's last patch looks right to me . r=ftang

Comment 19

17 years ago
I think there is a better way to set the destination to the empty string.
Instead of

  aDst = NS_LITERAL_STRING("");

we should simply have

  aDst.Truncate();

(This is how I solved it in my local tree.)
(Assignee)

Comment 20

17 years ago
change to moz0.9.1 and reassign to erik
Assignee: ftang → erik
Status: ASSIGNED → NEW
Target Milestone: mozilla0.9 → mozilla0.9.1
(Assignee)

Comment 21

16 years ago
erik resign. reassign all his bug to ftang for now.
Assignee: erik → ftang
(Assignee)

Comment 22

16 years ago
mark it as assign
Status: NEW → ASSIGNED
(Assignee)

Comment 23

16 years ago
We recycle this bug too much. Mark this bug fixed and keep the remaining one in 
80160. 
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 24

16 years ago
If you are going to move this issue then you will need to update the link on 
this page:

http://www.mozilla.org/projects/intl/bidi-progress.html
You need to log in before you can comment on or make changes to this bug.