70028 - landing of nsIUBidiUtils.h and implementation

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Comment 1

[Frank Tang]

Attachment: nsIUBidiUtils.h without Arabic shapping functions

Comment 2

[Frank Tang]

Attachment: bidicattable.h

Comment 3

[Frank Tang]

Attachment: symmtable.h

Comment 4

[Frank Tang]

Attachment: nsBidiUtilsImp.h

Comment 5

[Frank Tang]

Attachment: nsBidiUtilsImp.cpp

Comment 6

[Frank Tang]

submit by [e-mail]
r=ftang
sr=erik

Comment 7

[Frank Tang]

check in these 5 files. Need to add into the build after nsIBidi.h land.

Comment 8

[Erik van der Poel]

Simon, if you like, I think it's possible to change all of your softel.co.il
entries in bugzilla to your IBM address. (You don't have to do this; I just
thought you might want to.)

Comment 9

[Simon Montagu :smontagu]

Attachment: Adding gensymmtable.pl (generates the version of symmtable.h in attachment 26080 above)

Comment 10

[Teruko Kobayashi]

Changed QA contact to [e-mail].

Comment 11

[Frank Tang]

r=ftang

Comment 12

[Erik van der Poel]

previous r=ftang was for gensymmtable.pl

sr=erik for the same file

Comment 13

[Erik van der Poel]

gensymmtable.pl changes checked in. Makefiles not checked in yet.

Comment 14

[Frank Tang]

Check in most of the code. But we still need to review the Arabic shapping code. 
That part is still not fully work. I check in the code in a #ifdef which default 
to false. 

Comment 15

[Frank Tang]

Mark the remainning part as moz0.9

Comment 16

[Simon Montagu :smontagu]

The code within #ifdef FULL_ARABIC_SHAPING doesn't build as is.

NS_ConvertToString is no longer defined (see bug 73339), and should be replaced
by NS_LITERAL_STRING.

aSrcUnichars should be replaced by srcUnichars throughout for coding convention
compliance

Comment 17

[Simon Montagu :smontagu]

Attachment: diffs on nsBidiUtilsImp.cpp

Comment 18

[Frank Tang]

simon's last patch looks right to me . r=ftang

Comment 19

[Erik van der Poel]

I think there is a better way to set the destination to the empty string.
Instead of

  aDst = NS_LITERAL_STRING("");

we should simply have

  aDst.Truncate();

(This is how I solved it in my local tree.)

Comment 20

[Frank Tang]

change to moz0.9.1 and reassign to erik

Comment 21

[Frank Tang]

erik resign. reassign all his bug to ftang for now.

Comment 22

[Frank Tang]

mark it as assign

Comment 23

[Frank Tang]

We recycle this bug too much. Mark this bug fixed and keep the remaining one in 
80160. 

Comment 24

[Arthur Barrett]

If you are going to move this issue then you will need to update the link on 
this page:

http://www.mozilla.org/projects/intl/bidi-progress.html