Created attachment 26078 [details]
nsIUBidiUtils.h without Arabic shapping functions
Created attachment 26079 [details]
Created attachment 26080 [details]
Created attachment 26081 [details]
Created attachment 26082 [details]
submit by firstname.lastname@example.org
check in these 5 files. Need to add into the build after nsIBidi.h land.
Simon, if you like, I think it's possible to change all of your softel.co.il
entries in bugzilla to your IBM address. (You don't have to do this; I just
thought you might want to.)
Created attachment 26253 [details]
Adding gensymmtable.pl (generates the version of symmtable.h in attachment 26080 [details] above)
Changed QA contact to email@example.com.
previous r=ftang was for gensymmtable.pl
sr=erik for the same file
gensymmtable.pl changes checked in. Makefiles not checked in yet.
Check in most of the code. But we still need to review the Arabic shapping code.
That part is still not fully work. I check in the code in a #ifdef which default
Mark the remainning part as moz0.9
The code within #ifdef FULL_ARABIC_SHAPING doesn't build as is.
NS_ConvertToString is no longer defined (see bug 73339), and should be replaced
aSrcUnichars should be replaced by srcUnichars throughout for coding convention
Created attachment 29402 [details] [diff] [review]
diffs on nsBidiUtilsImp.cpp
simon's last patch looks right to me . r=ftang
I think there is a better way to set the destination to the empty string.
aDst = NS_LITERAL_STRING("");
we should simply have
(This is how I solved it in my local tree.)
change to moz0.9.1 and reassign to erik
erik resign. reassign all his bug to ftang for now.
mark it as assign
We recycle this bug too much. Mark this bug fixed and keep the remaining one in
If you are going to move this issue then you will need to update the link on