fix balrog database to be compatible with MySQL

RESOLVED FIXED

Status

RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: bhearsum, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 572448 [details] [diff] [review]
add lengths to string columns

When it got deployed to the dev environment, we had a Traceback that ended with:
[Fri Nov 04 12:50:32 2011] [error] [client 10.8.33.248]   File "/usr/lib/python2.6/site-packages/sqlalchemy/sql/visitors.py", line 59, in _compiler_dispatch
[Fri Nov 04 12:50:32 2011] [error] [client 10.8.33.248]     return getter(visitor)(self, **kw)
[Fri Nov 04 12:50:32 2011] [error] [client 10.8.33.248]   File "/usr/lib/python2.6/site-packages/sqlalchemy/sql/compiler.py", line 1587, in visit_string
[Fri Nov 04 12:50:32 2011] [error] [client 10.8.33.248]     return self.visit_VARCHAR(type_)
[Fri Nov 04 12:50:32 2011] [error] [client 10.8.33.248]   File "/usr/lib/python2.6/site-packages/sqlalchemy/dialects/mysql/base.py", line 1656, in visit_VARCHAR
[Fri Nov 04 12:50:32 2011] [error] [client 10.8.33.248]     self.dialect.name)
[Fri Nov 04 12:50:32 2011] [error] [client 10.8.33.248] InvalidRequestError: VARCHAR requires a length on dialect mysql

Setting a length on all of the String columns fixes this.

I also changed the 'options' field in Permissions to be Text, because it's a JSON blob.
Attachment #572448 - Flags: review?(catlee)

Updated

7 years ago
Attachment #572448 - Flags: review?(catlee) → review+
(Reporter)

Updated

7 years ago
Attachment #572448 - Flags: checked-in+
(Reporter)

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Product: mozilla.org → Release Engineering
mass component change
Component: Other → Balrog: Backend
Flags: checked-in+
You need to log in before you can comment on or make changes to this bug.