Closed
Bug 700324
Opened 13 years ago
Closed 13 years ago
[prod] ISE: MultiValueDictKeyError: "Key 'code' not found in <QueryDict: {}>"
Categories
(Participation Infrastructure :: Phonebook, defect)
Participation Infrastructure
Phonebook
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: mbrandt, Assigned: tofumatt)
References
()
Details
(Whiteboard: [prod])
From http://mozillians.org/zh-TW/confirm
Traceback (most recent call last):
File "/data/www/mozillians.org/mozillians/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File "/data/www/mozillians.org/mozillians/apps/users/views.py", line 48, in confirm
code = request.GET['code']
File "/data/www/mozillians.org/mozillians/vendor/src/django/django/utils/datastructures.py", line 258, in __getitem__
raise MultiValueDictKeyError("Key %r not found in %r" % (key, self))
MultiValueDictKeyError: "Key 'code' not found in <QueryDict: {}>"
Reporter | ||
Comment 1•13 years ago
|
||
A bit more information:
'HTTP_FROM': 'googlebot(at)googlebot.com',
Assignee | ||
Comment 2•13 years ago
|
||
This is semi-expected behaviour -- you can't confirm an account without a query string that contains the key "code". That said, we should handle the error slightly more gracefully. It's only happening because the google bot is hitting a page we don't really want it to hit. I'll fix this up for 1.2 (it's an easy fix).
Assignee: nobody → tofumatt
Target Milestone: --- → 1.2
Reporter | ||
Comment 3•13 years ago
|
||
Yay :)
Comment 4•13 years ago
|
||
Commit pushed to https://github.com/mozilla/mozillians
https://github.com/mozilla/mozillians/commit/932c6b813a2ec2200ec83761507b3207d97af00d
Check for GET param in confirm view (fix bug 700324)
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 5•13 years ago
|
||
Nice unit tests (comment 4)! Knocking to qa verified per https://github.com/mozilla/mozillians/commit/932c6b813a2ec2200ec83761507b3207d97af00d#L1R50. Will reopen if we start seeing these on prod again but I doubt it.
Status: RESOLVED → VERIFIED
Reporter | ||
Updated•13 years ago
|
Component: mozillians.org → Phonebook
Product: Websites → Community Tools
QA Contact: mozillians-org → phonebook
Target Milestone: 1.2 → ---
Version: unspecified → other
You need to log in
before you can comment on or make changes to this bug.
Description
•