700345 - CSS media tag modification on all Add-on pages

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Terry R.]

Yesterday, I found this add-on and thought it is a great tool for Firefox.
https://addons.mozilla.org/en-US/firefox/addon/print-edit/

However when I tested the Print Preview, that page rendered horrible.  I
checked 3 other browsers with the same results.

Checking the CSS on the Add-on page, I found this tag. <link rel="stylesheet"
media="screen,projection,tv"...  I'm wondering why "print" was not
included, or it be, "media=all" instead.

I checked another page and it had the same tag (as well as the Add-ons Home page), so I was wondering whether the default template contains the code.  If it is, it would be nice to have that modified.  I don't know what could be done about all the existing pages.

Comment 1

[Wil Clouser [:clouserw]]

no idea, CCing some front end folks

Comment 2

[Gregory Koberger (:gkoberger)]

I see no reason why it isn't "all". I tested, and it seems fine if we use "all".

It's a jingo-minify "bug", so I'm CCing jsocol and davedash to see if they have any objections before I change it.

https://github.com/jsocol/jingo-minify/blob/master/jingo_minify/helpers.py#L55

Comment 3

[James Socol [:jsocol, :james]]

It's working as intended, the css helper allows you to specify other values for media.

If we're going to change it to "all" by default, can we make a Django setting to switch the default back? Some of us rely on this behavior for print style sheets, and changing the css helper call at every call site is annoying.

Comment 4

[Gregory Koberger (:gkoberger)]

James is right. Maybe we should make the "default" an option? I can see why it would make sense either way.

In AMO's case, it makes sense to use 'all' since we don't want to write out 'all' each time we call "css()" and we don't have print stylesheets.

On other sites that actually use print stylesheets, it would be a pain to type out 'screen,tv,projection' each time you call "css()".

So, if we had an option in settings.py, we could let each site specify what makes sense for them. If we do this (and I think we should), it would make sense for us to leave the current default alone (so we don't break anything) and override it for AMO.

Comment 5

[Gregory Koberger (:gkoberger)]

Doesn't break or change any other jingo-minify site, but allows projects to specify a "CSS_MEDIA_DEFAULT" in settings.py.

https://github.com/mozilla/zamboni/commit/672f9f9fb