fix showBookmarkDialog warnings

RESOLVED FIXED in Firefox 11

Status

()

Firefox
Bookmarks & History
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

Trunk
Firefox 11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Looks like I forgot to pass into the window handle, that works regardless thanks to a compatibility shim, but complains loudly in the Error Console :(
(Assignee)

Updated

6 years ago
Blocks: 629371
(Assignee)

Comment 1

6 years ago
Created attachment 572896 [details] [diff] [review]
patch v1.0

this adds the missing argument
Attachment #572896 - Flags: review?(dietrich)
Comment on attachment 572896 [details] [diff] [review]
patch v1.0

Review of attachment 572896 [details] [diff] [review]:
-----------------------------------------------------------------

r=me w/ question addressed

::: browser/components/sidebar/src/nsSidebar.js
@@ +115,5 @@
>                                                         , "loadInSidebar" ]
>                                           , uri: uri
>                                           , title: aTitle
>                                           , loadBookmarkInSidebar: true
> +                                         }, win);

why changing minimal ui param here?
Attachment #572896 - Flags: review?(dietrich) → review+
(Assignee)

Comment 3

6 years ago
(In reply to Dietrich Ayala (:dietrich) from comment #2)
> why changing minimal ui param here?

it's a compatibility shim for addons, actually the method figures itself if it's minimalui bu checking if the folderPicker is in hiddenrows. We are not addons :)
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e2b0e520559
Target Milestone: --- → Firefox 11
https://hg.mozilla.org/mozilla-central/rev/9e2b0e520559
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.