Closed
Bug 700348
Opened 14 years ago
Closed 14 years ago
fix showBookmarkDialog warnings
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 11
People
(Reporter: mak, Assigned: mak)
References
Details
Attachments
(1 file)
|
11.72 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
Looks like I forgot to pass into the window handle, that works regardless thanks to a compatibility shim, but complains loudly in the Error Console :(
|
Assignee | |
Comment 1•14 years ago
|
||
this adds the missing argument
Attachment #572896 -
Flags: review?(dietrich)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 572896 [details] [diff] [review]
patch v1.0
Review of attachment 572896 [details] [diff] [review]:
-----------------------------------------------------------------
r=me w/ question addressed
::: browser/components/sidebar/src/nsSidebar.js
@@ +115,5 @@
> , "loadInSidebar" ]
> , uri: uri
> , title: aTitle
> , loadBookmarkInSidebar: true
> + }, win);
why changing minimal ui param here?
Attachment #572896 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
(In reply to Dietrich Ayala (:dietrich) from comment #2)
> why changing minimal ui param here?
it's a compatibility shim for addons, actually the method figures itself if it's minimalui bu checking if the folderPicker is in hiddenrows. We are not addons :)
|
|
Assignee | |
Comment 4•14 years ago
|
||
Target Milestone: --- → Firefox 11
|
||
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•