Closed Bug 700376 Opened 8 years ago Closed 8 years ago

Add support for building NSPR on Gonk

Categories

(NSPR :: NSPR, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(1 file, 1 obsolete file)

Gonk is pretty much identical to Android (Bionic) from the NSPR POV, but we locate the toolchain and headers differently.
Attached patch Gonk support (obsolete) — Splinter Review
This is fairly minimal since we let the top level config do all the work.
Attachment #572574 - Flags: review?(ted.mielczarek)
Comment on attachment 572574 [details] [diff] [review]
Gonk support

Review of attachment 572574 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with some more comments.

::: nsprpub/configure.in
@@ +165,5 @@
>  
> +AC_ARG_WITH(gonk,
> +[  --with-gonk=DIR
> +               location of gonk dir],
> +    gonkdir=$withval)

Can you add some comments here? This is not self-explanatory at all, and I had to ask someone what gonk was today. It's not even googleable at this point.

@@ +190,2 @@
>  case "$target" in
>  *-android*|*-linuxandroid*)

So when building for gonk, the target is still *-android*?
Attachment #572574 - Flags: review?(ted.mielczarek) → review+
(In reply to Ted Mielczarek [:ted, :luser] from comment #2)
> ::: nsprpub/configure.in
> @@ +165,5 @@
> >  
> > +AC_ARG_WITH(gonk,
> > +[  --with-gonk=DIR
> > +               location of gonk dir],
> > +    gonkdir=$withval)
> 
> Can you add some comments here? This is not self-explanatory at all, and I
> had to ask someone what gonk was today. It's not even googleable at this
> point.
> 

Sure.

> @@ +190,2 @@
> >  case "$target" in
> >  *-android*|*-linuxandroid*)
> 
> So when building for gonk, the target is still *-android*?

Yeah. Gonk shares enough with Android that it ended up easier this way, IIRC.
FTR, and inevitable Wikipedia citation, what's the etymology of "Gonk"?
Superficially, it comes from http://starwars.wikia.com/wiki/GNK_power_droid, which is my favorite droid from Star Wars.  There's also a deeper meaning that I'll leave for historians to speculate on.
Attached patch Gonk support, v2Splinter Review
Comment added. Can someone land this for me?
Attachment #572574 - Attachment is obsolete: true
Bump! Could somebody please land this in nspr and update m-c accordingly? Ted perhaps? Thanks!
Blocks: 709468
Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.316; previous revision: 1.315
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.318; previous revision: 1.317
done
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Thanks, Ted! Is there a bug for uplifting the next NSPR release to m-c yet?
(In reply to Philipp von Weitershausen [:philikon] from comment #9)
> Thanks, Ted! Is there a bug for uplifting the next NSPR release to m-c yet?

Never mind, I see Ed updated NSPR today. Woo!
Target Milestone: --- → 4.9
You need to log in before you can comment on or make changes to this bug.