700434 - Dismiss doorhangers on pressing back / tapping outside

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Sriram Ramasubramanian [:sriram]]

The doorhangers should be hidden when pressing back or tapping outside.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: PAtch (1/2): Dismisses doorhangers on touching outside

This patch dismisses doorhangers on touching outside them. The doorhanger container is hidden and shown back when the tab is revisted. DoorHangers are left untouched (as desired).

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch (2/2): Option 1: Dismiss doorhangers on back by taking focus.

This dismiss the DoorHangerPopup on pressing back key. This steals the focus from the window.
Earlier we had a discussion on DoorHangerPopup should not steal the focus. I am just having this as an option. Soon uploading the second option.

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch (2/2): Option 2: Dismiss doorhangers on back without stealing focus

This patch dismisses DoorHangerPopup on pressing back button. This doesn't steal the focus from the window.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 574464 [details] [diff] [review]
Patch (2/2): Option 1: Dismiss doorhangers on back by taking focus.

I don't think we want to steal focus

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 574462 [details] [diff] [review]
PAtch (1/2): Dismisses doorhangers on touching outside

I am having second thoughts about this. I am predicting that people are already tapping or in the process of tapping when the doorhanger appears. So the doorhanger dismisses too quickly.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 574462 [details] [diff] [review]
PAtch (1/2): Dismisses doorhangers on touching outside

I suppose we can try it and see what happens.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/projects/birch/rev/68edbb64aaee
https://hg.mozilla.org/projects/birch/rev/41964316c488

Comment 8

[Aaron Train [:aaronmt]]

Samsung Nexus S (Android 2.3.6)
20111116054452
http://hg.mozilla.org/projects/birch/rev/426690602cd5

Comment 9

[Aaron Train [:aaronmt]]

Tapping on the new tab (+) button dismisses the door hanger -- what if I made a mistake, and back out back to the page that prompted it (e.g, maps.google.com -> Hit (+) -> "Back" -- I expected to see the door hanger again).

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #9)
> Tapping on the new tab (+) button dismisses the door hanger -- what if I
> made a mistake, and back out back to the page that prompted it (e.g,
> maps.google.com -> Hit (+) -> "Back" -- I expected to see the door hanger
> again).

Doorhangers are re-shown on tab change, but bug 700437 will hopefully unify this a bit better.

Comment 11

[Camelia Urian]

Test cases added: BFT - General
https://litmus.mozilla.org/show_test.cgi?id=40444