Closed Bug 700434 Opened 9 years ago Closed 9 years ago

Dismiss doorhangers on pressing back / tapping outside

Categories

(Firefox for Android :: General, defect, P3)

All
Android
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: sriram, Assigned: sriram)

References

Details

(Whiteboard: [QA-])

Attachments

(3 files)

The doorhangers should be hidden when pressing back or tapping outside.
Assignee: nobody → sriram
Priority: -- → P3
This patch dismisses doorhangers on touching outside them. The doorhanger container is hidden and shown back when the tab is revisted. DoorHangers are left untouched (as desired).
Attachment #574462 - Flags: review?(mark.finkle)
This dismiss the DoorHangerPopup on pressing back key. This steals the focus from the window.
Earlier we had a discussion on DoorHangerPopup should not steal the focus. I am just having this as an option. Soon uploading the second option.
Attachment #574464 - Flags: review?(mark.finkle)
This patch dismisses DoorHangerPopup on pressing back button. This doesn't steal the focus from the window.
Attachment #574466 - Flags: review?(mark.finkle)
Comment on attachment 574464 [details] [diff] [review]
Patch (2/2): Option 1: Dismiss doorhangers on back by taking focus.

I don't think we want to steal focus
Attachment #574464 - Flags: review?(mark.finkle) → review-
Attachment #574466 - Flags: review?(mark.finkle) → review+
Comment on attachment 574462 [details] [diff] [review]
PAtch (1/2): Dismisses doorhangers on touching outside

I am having second thoughts about this. I am predicting that people are already tapping or in the process of tapping when the doorhanger appears. So the doorhanger dismisses too quickly.
Comment on attachment 574462 [details] [diff] [review]
PAtch (1/2): Dismisses doorhangers on touching outside

I suppose we can try it and see what happens.
Attachment #574462 - Flags: review?(mark.finkle) → review+
Samsung Nexus S (Android 2.3.6)
20111116054452
http://hg.mozilla.org/projects/birch/rev/426690602cd5
Status: RESOLVED → VERIFIED
Flags: in-litmus?(fennec)
Whiteboard: [QA+]
Tapping on the new tab (+) button dismisses the door hanger -- what if I made a mistake, and back out back to the page that prompted it (e.g, maps.google.com -> Hit (+) -> "Back" -- I expected to see the door hanger again).
(In reply to Aaron Train [:aaronmt] from comment #9)
> Tapping on the new tab (+) button dismisses the door hanger -- what if I
> made a mistake, and back out back to the page that prompted it (e.g,
> maps.google.com -> Hit (+) -> "Back" -- I expected to see the door hanger
> again).

Doorhangers are re-shown on tab change, but bug 700437 will hopefully unify this a bit better.
Test cases added: BFT - General
https://litmus.mozilla.org/show_test.cgi?id=40444
Flags: in-litmus?(fennec) → in-litmus+
Whiteboard: [QA+] → [QA-]
tracking-fennec: --- → 11+
You need to log in before you can comment on or make changes to this bug.