Dismiss doorhangers on pressing back / tapping outside

VERIFIED FIXED

Status

()

Firefox for Android
General
P3
normal
VERIFIED FIXED
6 years ago
9 months ago

People

(Reporter: sriram, Assigned: sriram)

Tracking

unspecified
All
Android
Points:
---
Bug Flags:
in-litmus +

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

(Whiteboard: [QA-])

Attachments

(3 attachments)

(Assignee)

Description

6 years ago
The doorhangers should be hidden when pressing back or tapping outside.
(Assignee)

Updated

6 years ago
Assignee: nobody → sriram

Updated

6 years ago
Priority: -- → P3
Blocks: 702281
(Assignee)

Comment 1

6 years ago
Created attachment 574462 [details] [diff] [review]
PAtch (1/2): Dismisses doorhangers on touching outside

This patch dismisses doorhangers on touching outside them. The doorhanger container is hidden and shown back when the tab is revisted. DoorHangers are left untouched (as desired).
Attachment #574462 - Flags: review?(mark.finkle)
(Assignee)

Comment 2

6 years ago
Created attachment 574464 [details] [diff] [review]
Patch (2/2): Option 1: Dismiss doorhangers on back by taking focus.

This dismiss the DoorHangerPopup on pressing back key. This steals the focus from the window.
Earlier we had a discussion on DoorHangerPopup should not steal the focus. I am just having this as an option. Soon uploading the second option.
Attachment #574464 - Flags: review?(mark.finkle)
(Assignee)

Comment 3

6 years ago
Created attachment 574466 [details] [diff] [review]
Patch (2/2): Option 2: Dismiss doorhangers on back without stealing focus

This patch dismisses DoorHangerPopup on pressing back button. This doesn't steal the focus from the window.
Attachment #574466 - Flags: review?(mark.finkle)
Comment on attachment 574464 [details] [diff] [review]
Patch (2/2): Option 1: Dismiss doorhangers on back by taking focus.

I don't think we want to steal focus
Attachment #574464 - Flags: review?(mark.finkle) → review-
Attachment #574466 - Flags: review?(mark.finkle) → review+
Comment on attachment 574462 [details] [diff] [review]
PAtch (1/2): Dismisses doorhangers on touching outside

I am having second thoughts about this. I am predicting that people are already tapping or in the process of tapping when the doorhanger appears. So the doorhanger dismisses too quickly.
Comment on attachment 574462 [details] [diff] [review]
PAtch (1/2): Dismisses doorhangers on touching outside

I suppose we can try it and see what happens.
Attachment #574462 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/projects/birch/rev/68edbb64aaee
https://hg.mozilla.org/projects/birch/rev/41964316c488
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Samsung Nexus S (Android 2.3.6)
20111116054452
http://hg.mozilla.org/projects/birch/rev/426690602cd5
Status: RESOLVED → VERIFIED
Flags: in-litmus?(fennec)
Whiteboard: [QA+]
Tapping on the new tab (+) button dismisses the door hanger -- what if I made a mistake, and back out back to the page that prompted it (e.g, maps.google.com -> Hit (+) -> "Back" -- I expected to see the door hanger again).
(In reply to Aaron Train [:aaronmt] from comment #9)
> Tapping on the new tab (+) button dismisses the door hanger -- what if I
> made a mistake, and back out back to the page that prompted it (e.g,
> maps.google.com -> Hit (+) -> "Back" -- I expected to see the door hanger
> again).

Doorhangers are re-shown on tab change, but bug 700437 will hopefully unify this a bit better.

Comment 11

6 years ago
Test cases added: BFT - General
https://litmus.mozilla.org/show_test.cgi?id=40444
Flags: in-litmus?(fennec) → in-litmus+
Whiteboard: [QA+] → [QA-]
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.